Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 2455493002: service worker: Propagate navigation preload flag to SWVersion. (Closed)
Patch Set: more comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_registration_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index e19b894a41e37f0c31ed5edeacd0e9a19982ad15..b77d042b4f68fcd16e6304116eea0155920725d0 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -170,9 +170,14 @@ class CONTENT_EXPORT ServiceWorkerVersion
foreign_fetch_origins_ = origins;
}
+ // Only meaningful if this version is active.
bool navigation_preload_enabled() const {
+ DCHECK(status_ == ACTIVATING || status_ == ACTIVATED) << status_;
return navigation_preload_enabled_;
}
+ // Only intended for use by ServiceWorkerRegistration. Generally use
+ // ServiceWorkerRegistration::EnableNavigationPreload instead of this
+ // function.
void set_navigation_preload_enabled(bool enabled) {
navigation_preload_enabled_ = enabled;
}
@@ -730,6 +735,10 @@ class CONTENT_EXPORT ServiceWorkerVersion
std::vector<GURL> foreign_fetch_scopes_;
std::vector<url::Origin> foreign_fetch_origins_;
FetchHandlerExistence fetch_handler_existence_;
+ // The source of truth for navigation preload state is the
+ // ServiceWorkerRegistration. |navigation_preload_enabled_| is essentially a
+ // cache for the state because it must be looked up quickly and a live
+ // registration doesn't necessarily exist whenever there is a live version.
bool navigation_preload_enabled_ = false;
ServiceWorkerMetrics::Site site_for_uma_;
« no previous file with comments | « content/browser/service_worker/service_worker_registration_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698