Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2455483002: Use v8::TryCatch in toImplSequence (Closed)

Created:
4 years, 1 month ago by bashi
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use v8::TryCatch in toImplSequence To transmit exceptions to ExceptionState. BUG=643049 Committed: https://crrev.com/19f37fd06b24d3af5e84f019e561d18c125a29e9 Cr-Commit-Position: refs/heads/master@{#427621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 5 chunks +19 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 1 chunk +15 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
bashi
PTAL
4 years, 1 month ago (2016-10-26 02:14:41 UTC) #4
haraken
LGTM Maybe the lesson we learned is that an API that returns a MaybeLocal handle ...
4 years, 1 month ago (2016-10-26 05:49:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455483002/1
4 years, 1 month ago (2016-10-26 05:54:04 UTC) #9
bashi
On 2016/10/26 05:49:49, haraken wrote: > LGTM > > Maybe the lesson we learned is ...
4 years, 1 month ago (2016-10-26 05:55:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 07:11:40 UTC) #11
dominicc (has gone to gerrit)
On 2016/10/26 at 05:55:35, bashi wrote: > On 2016/10/26 05:49:49, haraken wrote: > > LGTM ...
4 years, 1 month ago (2016-10-26 07:12:16 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 07:15:13 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19f37fd06b24d3af5e84f019e561d18c125a29e9
Cr-Commit-Position: refs/heads/master@{#427621}

Powered by Google App Engine
This is Rietveld 408576698