Use v8::TryCatch in toImplSequence

Use v8::TryCatch in toImplSequence

To transmit exceptions to ExceptionState.

BUG=643049
Committed: https://crrev.com/19f37fd06b24d3af5e84f019e561d18c125a29e9
Cr-Commit-Position: refs/heads/master@{#427621}

[bashi, 2016-10-26 02:14:02]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 02:14:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2016-10-26 02:14:41]

bashi@chromium.org changed reviewers:
+ dominicc@chromium.org, haraken@chromium.org

[bashi, 2016-10-26 02:14:41]

PTAL

[commit-bot: I haz the power, 2016-10-26 02:17:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 02:17:23]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[haraken, 2016-10-26 05:49:49]

LGTM

Maybe the lesson we learned is that an API that returns a MaybeLocal handle
should not take ExceptionState as a parameter?

[bashi, 2016-10-26 05:53:47]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2016-10-26 05:54:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2016-10-26 05:55:35]

On 2016/10/26 05:49:49, haraken wrote:
> LGTM
> 
> Maybe the lesson we learned is that an API that returns a MaybeLocal handle
> should not take ExceptionState as a parameter?

Yes. I think so. That's unfortunate that we have to use v8::TryCatch to move
around exceptions...

[commit-bot: I haz the power, 2016-10-26 07:11:40]

Committed patchset #1 (id:1)

[dominicc (has gone to gerrit), 2016-10-26 07:12:16]

On 2016/10/26 at 05:55:35, bashi wrote:
> On 2016/10/26 05:49:49, haraken wrote:
> > LGTM
> > 
> > Maybe the lesson we learned is that an API that returns a MaybeLocal handle
> > should not take ExceptionState as a parameter?
> 
> Yes. I think so. That's unfortunate that we have to use v8::TryCatch to move
around exceptions...

Thank you for fixing this. custom-elements test LGTM.

[commit-bot: I haz the power, 2016-10-26 07:15:12]

Description was changed from

==========
Use v8::TryCatch in toImplSequence

To transmit exceptions to ExceptionState.

BUG=643049
==========

to

==========
Use v8::TryCatch in toImplSequence

To transmit exceptions to ExceptionState.

BUG=643049

Committed: https://crrev.com/19f37fd06b24d3af5e84f019e561d18c125a29e9
Cr-Commit-Position: refs/heads/master@{#427621}
==========

[commit-bot: I haz the power, 2016-10-26 07:15:13]

Patchset 1 (id:??) landed as
https://crrev.com/19f37fd06b24d3af5e84f019e561d18c125a29e9
Cr-Commit-Position: refs/heads/master@{#427621}