Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html

Issue 2455483002: Use v8::TryCatch in toImplSequence (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html
diff --git a/third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html b/third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html
index 729a6cb0d423b5f87635ea4eccfb8e03236511d8..2c8d64587e2c38351ce0b7ca8de3da3e59c7f6d0 100644
--- a/third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html
+++ b/third_party/WebKit/LayoutTests/custom-elements/spec/define-element.html
@@ -410,5 +410,22 @@ test_with_window((w) => {
assert_false( observedAttributes_invoked, 'Get(constructor, observedAttributes) should not be invoked');
}, 'Get(constructor, observedAttributes) should not execute if ' +
'attributeChangedCallback is undefined');
+
+test_with_window((w) => {
+ let attributes = {};
+ attributes[Symbol.iterator] = function*() {
+ throw new TypeError();
+ };
+ class X extends w.HTMLElement {
+ constructor() { super(); }
+ attributeChangedCallback() {}
+ static get observedAttributes() {
+ return attributes;
+ }
+ }
+ assert_throws(TypeError.prototype, () => {
+ w.customElements.define('x-x', X);
+ });
+}, 'Throwing an exception in observedAttributes');
</script>
</body>
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698