Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2455463002: Remove references to DrMemory from chromium repo. (Closed)

Created:
4 years, 1 month ago by benwells
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, Dirk Pranke, Nico
CC:
chromium-reviews, tfarina, agrieve+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to DrMemory from chromium repo. This removes references to DrMemory for MB, GN and buildbot, and also removes references to redundant DrMemory bots and DrMemory targets. BUG=655521, 644217 Committed: https://crrev.com/e02ee8681a05a4e85552ec37e2a6999b0f2e76d9 Cr-Commit-Position: refs/heads/master@{#430388}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Buildbot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2554 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -72 lines 0 comments Download
M PRESUBMIT_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.full.json View 1 2 2 chunks +0 lines, -1218 lines 0 comments Download
M testing/buildbot/chromium.memory.full.json View 1 2 2 chunks +0 lines, -1218 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 1 chunk +0 lines, -8 lines 0 comments Download
M testing/buildbot/manage.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/re2/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/gn/docs/cookbook.md View 1 chunk +0 lines, -1 line 0 comments Download
M tools/mb/mb_config.pyl View 1 5 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
benwells
Looks like I forgot to sent this :|
4 years, 1 month ago (2016-11-01 04:49:00 UTC) #10
Dirk Pranke
On 2016/11/01 04:49:00, benwells (slow) wrote: > Looks like I forgot to sent this :| ...
4 years, 1 month ago (2016-11-01 16:44:43 UTC) #11
benwells
On 2016/11/01 16:44:43, Dirk Pranke wrote: > On 2016/11/01 04:49:00, benwells (slow) wrote: > > ...
4 years, 1 month ago (2016-11-02 21:35:18 UTC) #12
benwells
Now with buildot files updated...
4 years, 1 month ago (2016-11-06 22:47:29 UTC) #15
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-07 18:29:08 UTC) #18
benwells
+thakis for third_party/re2 build file
4 years, 1 month ago (2016-11-07 21:37:13 UTC) #21
Nico
lgtm
4 years, 1 month ago (2016-11-07 21:47:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455463002/40001
4 years, 1 month ago (2016-11-07 21:48:17 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-07 21:55:45 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 22:22:02 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e02ee8681a05a4e85552ec37e2a6999b0f2e76d9
Cr-Commit-Position: refs/heads/master@{#430388}

Powered by Google App Engine
This is Rietveld 408576698