Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Unified Diff: third_party/re2/BUILD.gn

Issue 2455463002: Remove references to DrMemory from chromium repo. (Closed)
Patch Set: Buildbot Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/buildbot/manage.py ('k') | tools/gn/docs/cookbook.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/re2/BUILD.gn
diff --git a/third_party/re2/BUILD.gn b/third_party/re2/BUILD.gn
index b827d59d12bd2c1dd72b49c63f5d49eaac37318a..9563f6a19ec824cf1d4631a9cfac970147fc647d 100644
--- a/third_party/re2/BUILD.gn
+++ b/third_party/re2/BUILD.gn
@@ -60,10 +60,4 @@ static_library("re2") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
public_configs = [ ":re2_config" ]
-
- # TODO(battre) If Dr. Memory is ever migrated to GN, a flag needs to be
- # added for this that adds a MEMORY_SANITIZER define. See re2.gyp.
- # if (is_drmemory) {
- # defines += [ "MEMORY_SANITIZER" ]
- # }
}
« no previous file with comments | « testing/buildbot/manage.py ('k') | tools/gn/docs/cookbook.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698