chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc - Issue 2455343003: [Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc

Issue 2455343003: [Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks. (Closed)

Patch Set: \Updates for Max and rebase. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc ('k') | chrome/browser/sync/test/integration/sync_auth_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc b/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc

index 5c517169697a527d42218f52fb41c56b67ef455f..0725b5cec01d30f81d8c5bd3200e5156aa09f2bb 100644

--- a/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc

+++ b/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc

@@ -119,7 +119,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, Download) {

ASSERT_TRUE(SetupSync()) << "SetupSync() failed";

autofill::PersonalDataManager* pdm = GetPersonalDataManager(0);

- ASSERT_TRUE(pdm != nullptr);

+ ASSERT_NE(nullptr, pdm);

std::vector<autofill::CreditCard*> cards = pdm->GetCreditCards();

ASSERT_EQ(1uL, cards.size());

@@ -141,7 +141,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, ClearOnDisableSync) {

// Make sure the card is in the DB.

autofill::PersonalDataManager* pdm = GetPersonalDataManager(0);

- ASSERT_TRUE(pdm != nullptr);

+ ASSERT_NE(nullptr, pdm);

std::vector<autofill::CreditCard*> cards = pdm->GetCreditCards();

ASSERT_EQ(1uL, cards.size());

@@ -159,7 +159,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, ClearOnDisableWalletSync) {

// Make sure the card is in the DB.

autofill::PersonalDataManager* pdm = GetPersonalDataManager(0);

- ASSERT_TRUE(pdm != nullptr);

+ ASSERT_NE(nullptr, pdm);

std::vector<autofill::CreditCard*> cards = pdm->GetCreditCards();

ASSERT_EQ(1uL, cards.size());

@@ -178,7 +178,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest,

// Make sure the card is in the DB.

autofill::PersonalDataManager* pdm = GetPersonalDataManager(0);

- ASSERT_TRUE(pdm != nullptr);

+ ASSERT_NE(nullptr, pdm);

std::vector<autofill::CreditCard*> cards = pdm->GetCreditCards();

ASSERT_EQ(1uL, cards.size());