Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: components/browser_sync/profile_sync_service_autofill_unittest.cc

Issue 2455343003: [Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks. (Closed)
Patch Set: Fixing EQ/NE mistake. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/profile_sync_service_autofill_unittest.cc
diff --git a/components/browser_sync/profile_sync_service_autofill_unittest.cc b/components/browser_sync/profile_sync_service_autofill_unittest.cc
index 4efb37c7778d9f6322c90a2dcbedc4fb1410f80a..1e265c281ce13059eb4ce83ac2b542527c150b79 100644
--- a/components/browser_sync/profile_sync_service_autofill_unittest.cc
+++ b/components/browser_sync/profile_sync_service_autofill_unittest.cc
@@ -849,7 +849,7 @@ TEST_F(ProfileSyncServiceAutofillTest, HasNativeEntriesEmptySync) {
std::vector<AutofillProfile> sync_profiles;
ASSERT_TRUE(GetAutofillEntriesFromSyncDB(&sync_entries, &sync_profiles));
ASSERT_EQ(1U, entries.size());
maxbogue 2016/10/28 23:31:00 I'm like... reasonably sure this was supposed to b
skym 2016/10/31 15:08:18 I agree, done.
- EXPECT_TRUE(entries[0] == sync_entries[0]);
+ EXPECT_EQ(entries[0], sync_entries[0]);
EXPECT_EQ(0U, sync_profiles.size());
}
@@ -931,7 +931,7 @@ TEST_F(ProfileSyncServiceAutofillTest, HasNativeHasSyncNoMerge) {
std::set<AutofillEntry> new_sync_entries_set(new_sync_entries.begin(),
new_sync_entries.end());
- EXPECT_TRUE(expected_entries == new_sync_entries_set);
+ EXPECT_EQ(expected_entries, new_sync_entries_set);
}
TEST_F(ProfileSyncServiceAutofillTest, HasNativeHasSyncMergeEntry) {
@@ -960,7 +960,7 @@ TEST_F(ProfileSyncServiceAutofillTest, HasNativeHasSyncMergeEntry) {
ASSERT_TRUE(
GetAutofillEntriesFromSyncDB(&new_sync_entries, &new_sync_profiles));
ASSERT_EQ(1U, new_sync_entries.size());
- EXPECT_TRUE(merged_entry == new_sync_entries[0]);
+ EXPECT_EQ(merged_entry, new_sync_entries[0]);
}
TEST_F(ProfileSyncServiceAutofillTest, HasNativeHasSyncMergeProfile) {
@@ -1326,7 +1326,7 @@ TEST_F(ProfileSyncServiceAutofillTest, ProcessUserChangeAddEntry) {
ASSERT_TRUE(
GetAutofillEntriesFromSyncDB(&new_sync_entries, &new_sync_profiles));
ASSERT_EQ(1U, new_sync_entries.size());
- EXPECT_TRUE(added_entry == new_sync_entries[0]);
+ EXPECT_EQ(added_entry, new_sync_entries[0]);
}
TEST_F(ProfileSyncServiceAutofillTest, ProcessUserChangeAddProfile) {
@@ -1383,7 +1383,7 @@ TEST_F(ProfileSyncServiceAutofillTest, ProcessUserChangeUpdateEntry) {
ASSERT_TRUE(
GetAutofillEntriesFromSyncDB(&new_sync_entries, &new_sync_profiles));
ASSERT_EQ(1U, new_sync_entries.size());
- EXPECT_TRUE(updated_entry == new_sync_entries[0]);
+ EXPECT_EQ(updated_entry, new_sync_entries[0]);
}
TEST_F(ProfileSyncServiceAutofillTest, ProcessUserChangeRemoveEntry) {

Powered by Google App Engine
This is Rietveld 408576698