[Sync] Replaced ASSERT/EXPECT_TRUE/FALSE with expected/actual checks.

chrome/browser/sync/test/integration/sync_test.cc

Index: chrome/browser/sync/test/integration/sync_test.cc
diff --git a/chrome/browser/sync/test/integration/sync_test.cc b/chrome/browser/sync/test/integration/sync_test.cc
index 0858f0e433830623b2c2b32ca34c68768a412a30..425186ab6972824d67e6f651fcc84d1d9ad95113 100644
--- a/chrome/browser/sync/test/integration/sync_test.cc
+++ b/chrome/browser/sync/test/integration/sync_test.cc
@@ -527,8 +527,8 @@ void SyncTest::InitializeProfile(int index, Profile* profile) {
   // CheckInitialState() assumes that no windows are open at startup.
   browsers_[index] = new Browser(Browser::CreateParams(GetProfile(index)));
 
-  EXPECT_FALSE(GetBrowser(index) == nullptr) << "Could not create Browser "
-                                             << index << ".";
+  EXPECT_NE(nullptr, GetBrowser(index)) << "Could not create Browser " << index
+                                        << ".";

[maxbogue, 2016/10/28 23:31:00]

Don't need no stinkin' .'s round these parts (and if you use "Couldn't" it will
all fit on one line..)

[skym, 2016/10/31 15:08:18]

Removed all << "." from this file. This fits on one line without using a
contraction, so leaving "Could not".

 
   // Make sure the ProfileSyncService has been created before creating the
   // ProfileSyncServiceHarness - some tests expect the ProfileSyncService to
@@ -553,8 +553,8 @@ void SyncTest::InitializeProfile(int index, Profile* profile) {
                                         username_,
                                         password_,
                                         singin_type);
-  EXPECT_FALSE(GetClient(index) == nullptr) << "Could not create Client "
-                                            << index << ".";
+  EXPECT_NE(nullptr, GetClient(index)) << "Could not create Client " << index
+                                       << ".";

[maxbogue, 2016/10/28 23:31:00]

psh

[skym, 2016/10/31 15:08:18]

Done.

   InitializeInvalidations(index);
 }
 
@@ -793,7 +793,7 @@ void SyncTest::SetupMockGaiaResponses() {
 void SyncTest::SetOAuth2TokenResponse(const std::string& response_data,
                                       net::HttpStatusCode response_code,
                                       net::URLRequestStatus::Status status) {
-  ASSERT_TRUE(nullptr != fake_factory_.get());
+  ASSERT_NE(nullptr, fake_factory_.get());
   fake_factory_->SetFakeResponse(GaiaUrls::GetInstance()->oauth2_token_url(),
                                  response_data, response_code, status);
 }