Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 2455303002: [MD Settings] Update the message in the sign out dialog for (non-)managed accounts. (Closed)

Created:
4 years, 1 month ago by Moe
Modified:
4 years, 1 month ago
Reviewers:
tommycli
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Settings] Update the message in the sign out dialog for (non-)managed accounts. BUG=640097, 640095 Committed: https://crrev.com/685f5586bab6fc956a133dd84de505ea5483833f Cr-Commit-Position: refs/heads/master@{#428511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M chrome/app/settings_strings.grdp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Moe
Tommy, please take a look at this CL. screenshots: https://screenshot.googleplex.com/ZTuKrbjmP4g https://screenshot.googleplex.com/hBVL9ACTffU
4 years, 1 month ago (2016-10-28 18:32:13 UTC) #9
tommycli
lgtm assuming manually tested.
4 years, 1 month ago (2016-10-28 20:58:28 UTC) #12
Moe
On 2016/10/28 20:58:28, tommycli wrote: > lgtm assuming manually tested. Thanks. yep manually verified.
4 years, 1 month ago (2016-10-28 21:06:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455303002/20001
4 years, 1 month ago (2016-10-28 21:06:43 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-10-28 22:07:25 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 22:09:54 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/685f5586bab6fc956a133dd84de505ea5483833f
Cr-Commit-Position: refs/heads/master@{#428511}

Powered by Google App Engine
This is Rietveld 408576698