Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2455273002: DevTools: Console now autocompletes on window for empty string (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Console now autocompletes on window for empty string BUG=659982 Committed: https://crrev.com/78b653a1157f70d99fc1caff0277798ce314b2bd Cr-Commit-Position: refs/heads/master@{#428529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
einbinder
ptal
4 years, 1 month ago (2016-10-27 23:13:16 UTC) #3
lushnikov
lgtm
4 years, 1 month ago (2016-10-27 23:37:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455273002/1
4 years, 1 month ago (2016-10-28 22:10:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 22:41:50 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 22:43:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78b653a1157f70d99fc1caff0277798ce314b2bd
Cr-Commit-Position: refs/heads/master@{#428529}

Powered by Google App Engine
This is Rietveld 408576698