third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js - Issue 2455273002: DevTools: Console now autocompletes on window for empty string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

Issue 2455273002: DevTools: Console now autocompletes on window for empty string (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js b/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

index c111f3f6fce0acf407c0a1c8de2cb16eaa1f6feb..acd14c9c8e3e146858be077d6b0d3d809455375a 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

@@ -276,7 +276,7 @@ WebInspector.ConsolePrompt.prototype = {

var prefix = this._editor.text(prefixRange);

var before = this._editor.text(new WebInspector.TextRange(0, 0, prefixRange.startLine, prefixRange.startColumn));

var historyWords = this._historyCompletions(prefix);

- WebInspector.ExecutionContextSelector.completionsForTextInCurrentContext(before, prefix, false /* Don't force */, innerWordsWithPrefix);

+ WebInspector.ExecutionContextSelector.completionsForTextInCurrentContext(before, prefix, true /* force */, innerWordsWithPrefix);

return promise;

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »