Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2455253002: Revert of Roll ANGLE af7f301..1d2c41d (Closed)

Created:
4 years, 1 month ago by mohsen
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll ANGLE af7f301..1d2c41d (patchset #1 id:1 of https://codereview.chromium.org/2457883002/ ) Reason for revert: Compile failure on buildbots: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20Builder/builds/121432 e:\b\c\b\win_layout\src\third_party\angle\src\libangle\renderer\d3d\d3d11\swapchain11.cpp(205): error C2220: warning treated as error - no 'object' file generated e:\b\c\b\win_layout\src\third_party\angle\src\libangle\renderer\d3d\d3d11\swapchain11.cpp(205): warning C4189: 'result': local variable is initialized but not referenced Original issue's description: > Roll ANGLE af7f301..1d2c41d > > https://chromium.googlesource.com/angle/angle.git/+log/af7f301..1d2c41d > > BUG=658555, chromium:659326, 540829, 655247 > > TBR=jmadill@chromium.org > > TEST=bots > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Committed: https://crrev.com/a16bd358e88a73acb35843f44719783f24087234 > Cr-Commit-Position: refs/heads/master@{#428138} TBR=jmadill@chromium.org,geofflang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=658555, chromium:659326, 540829, 655247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
mohsen
Created Revert of Roll ANGLE af7f301..1d2c41d
4 years, 1 month ago (2016-10-27 21:47:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455253002/1
4 years, 1 month ago (2016-10-27 21:48:10 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 21:50:40 UTC) #6
Failed to apply patch for DEPS:
While running git apply --index -3 -p1;
  error: patch failed: DEPS:51
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: DEPS: patch does not apply

Patch:       DEPS
Index: DEPS
diff --git a/DEPS b/DEPS
index
fb38e779fe0c26fbd003f9c1a1bde8b69b9cb495..7b084070b84e6b932e8feb963c7116490527a8fb
100644
--- a/DEPS
+++ b/DEPS
@@ -51,7 +51,7 @@
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling ANGLE
   # and whatever else without interference from each other.
-  'angle_revision': '1d2c41d612abb740b7a7f50dfa8ff6878ca1a144',
+  'angle_revision': 'af7f301f6ba9e5f31d1511142a936a9ba84169d0',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling build tools
   # and whatever else without interference from each other.

Powered by Google App Engine
This is Rietveld 408576698