Issue 245523002: Merge 264918 "Fix the output request size for AudioBufferConvert..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 245523002: Merge 264918 "Fix the output request size for AudioBufferConvert..." (Closed)

Created:
6 years, 8 months ago by DaleCurtis

Modified:
6 years, 8 months ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1916/src/

Visibility:
Public.

Merge 264918 "Fix the output request size for AudioBufferConvert..." > Fix the output request size for AudioBufferConverter requests. > > Previously too little data was converted because the code was > incorrectly assuming the FIFO was enabled. > > BUG=364990 > TEST=new unittest > TBR=scherkus > > Review URL: https://codereview.chromium.org/243573005 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265023

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -45 lines)			Patch
M	media/base/audio_buffer_converter.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	media/base/audio_buffer_converter.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	media/base/audio_buffer_converter_unittest.cc	View	3 chunks	+70 lines, -40 lines	0 comments	Download

Total messages: 2 (0 generated)

DaleCurtis

6 years, 8 months ago (2014-04-21 18:21:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r265023 (tree was closed).