Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 243573005: Fix the output request size for AudioBufferConverter requests. (Closed)

Created:
6 years, 8 months ago by DaleCurtis
Modified:
6 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix the output request size for AudioBufferConverter requests. Previously too little data was converted because the code was incorrectly assuming the FIFO was enabled. BUG=364990 TEST=new unittest TBR=scherkus Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264918

Patch Set 1 #

Patch Set 2 : Use for_testing() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -45 lines) Patch
M media/base/audio_buffer_converter.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M media/base/audio_buffer_converter.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M media/base/audio_buffer_converter_unittest.cc View 1 3 chunks +70 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
DaleCurtis
6 years, 8 months ago (2014-04-18 23:17:10 UTC) #1
rileya (GONE FROM CHROMIUM)
lgtm
6 years, 8 months ago (2014-04-19 00:12:16 UTC) #2
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 8 months ago (2014-04-19 00:14:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/243573005/20001
6 years, 8 months ago (2014-04-19 00:14:38 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-19 00:14:38 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-19 00:14:39 UTC) #6
DaleCurtis
Hmm rileya@ is a committer, so not sure why it's failing, but TBR=me
6 years, 8 months ago (2014-04-19 00:19:16 UTC) #7
DaleCurtis
By TBR=me I meant TBR=scherkus :)
6 years, 8 months ago (2014-04-19 00:19:54 UTC) #8
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 8 months ago (2014-04-19 00:20:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/243573005/20001
6 years, 8 months ago (2014-04-19 00:20:25 UTC) #10
commit-bot: I haz the power
Change committed as 264918
6 years, 8 months ago (2014-04-19 03:33:30 UTC) #11
scherkus (not reviewing)
6 years, 8 months ago (2014-04-21 17:25:12 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698