Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 2455223002: Fix LayoutTableSectionTest test cases which called a method on nil. (Closed)

Created:
4 years, 1 month ago by krasin1
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix LayoutTableSectionTest test cases which called a method on nil. In particular, section var was nil for the tests, which had document().body()->firstChild()->firstChild()->layoutObject()); These are switched to getLayoutObjectByElementId("section"), and also checks for section != NULL were added. The bug was found with running the test with UBSan. Also adding net_unittests to UBSanVptr ToT, as it has already been runnin on the regular UBSanVptr bot. BUG=607996 Committed: https://crrev.com/623cf72475439f27bdcb556616887366b7566094 Cr-Commit-Position: refs/heads/master@{#428259}

Patch Set 1 #

Patch Set 2 : Add webkit_unit_tests to bots #

Patch Set 3 : Add net_unittests on UBSanVptr ToT bot #

Total comments: 2

Patch Set 4 : fmt #

Patch Set 5 : fix bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 2 3 4 3 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSectionTest.cpp View 5 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 33 (20 generated)
krasin1
4 years, 1 month ago (2016-10-27 21:10:11 UTC) #3
Xianzhu
lgtm. The failure is weird, but the new code looks better. Is there a bug ...
4 years, 1 month ago (2016-10-27 21:14:22 UTC) #5
krasin1
On 2016/10/27 21:14:22, Xianzhu wrote: > lgtm. > > The failure is weird, but the ...
4 years, 1 month ago (2016-10-27 21:15:52 UTC) #7
krasin1
Hi Dirk, may I have your blessing for the //testing/buildbot/chromium.fyi.json changes? I have fixed all ...
4 years, 1 month ago (2016-10-27 21:17:28 UTC) #9
Dirk Pranke
https://codereview.chromium.org/2455223002/diff/40001/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2455223002/diff/40001/testing/buildbot/chromium.fyi.json#newcode4122 testing/buildbot/chromium.fyi.json:4122: "test": "net_unittests" Are you intentionally adding net_unittests in this ...
4 years, 1 month ago (2016-10-27 22:41:00 UTC) #10
krasin1
On 2016/10/27 22:41:00, Dirk Pranke wrote: > https://codereview.chromium.org/2455223002/diff/40001/testing/buildbot/chromium.fyi.json > File testing/buildbot/chromium.fyi.json (right): > > https://codereview.chromium.org/2455223002/diff/40001/testing/buildbot/chromium.fyi.json#newcode4122 ...
4 years, 1 month ago (2016-10-27 22:45:03 UTC) #12
krasin1
https://codereview.chromium.org/2455223002/diff/40001/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2455223002/diff/40001/testing/buildbot/chromium.fyi.json#newcode4122 testing/buildbot/chromium.fyi.json:4122: "test": "net_unittests" On 2016/10/27 22:40:59, Dirk Pranke wrote: > ...
4 years, 1 month ago (2016-10-27 23:51:29 UTC) #15
Dirk Pranke
ok, lgtm.
4 years, 1 month ago (2016-10-28 00:34:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455223002/80001
4 years, 1 month ago (2016-10-28 00:48:00 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/169731)
4 years, 1 month ago (2016-10-28 01:17:43 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455223002/80001
4 years, 1 month ago (2016-10-28 01:20:22 UTC) #29
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-10-28 02:35:44 UTC) #31
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 02:38:45 UTC) #33
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/623cf72475439f27bdcb556616887366b7566094
Cr-Commit-Position: refs/heads/master@{#428259}

Powered by Google App Engine
This is Rietveld 408576698