|
|
Created:
4 years, 1 month ago by krasin1 Modified:
4 years, 1 month ago CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix LayoutTableSectionTest test cases which called a method on nil.
In particular, section var was nil for the tests, which had
document().body()->firstChild()->firstChild()->layoutObject());
These are switched to getLayoutObjectByElementId("section"), and
also checks for section != NULL were added.
The bug was found with running the test with UBSan.
Also adding net_unittests to UBSanVptr ToT, as it has already been runnin on the regular UBSanVptr bot.
BUG=607996
Committed: https://crrev.com/623cf72475439f27bdcb556616887366b7566094
Cr-Commit-Position: refs/heads/master@{#428259}
Patch Set 1 #Patch Set 2 : Add webkit_unit_tests to bots #Patch Set 3 : Add net_unittests on UBSanVptr ToT bot #
Total comments: 2
Patch Set 4 : fmt #Patch Set 5 : fix bad merge #
Messages
Total messages: 33 (20 generated)
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
krasin@chromium.org changed reviewers: + wangxianzhu@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm. The failure is weird, but the new code looks better. Is there a bug of this? If not, please remove the BUG= line from description.
Description was changed from ========== Fix LayoutTableSectionTest test cases which called a method on nil. In particular, section var was nil for the tests, which had document().body()->firstChild()->firstChild()->layoutObject()); These are switched to getLayoutObjectByElementId("section"), and also checks for section != NULL were added. The bug was found with running the test with UBSan. BUG= ========== to ========== Fix LayoutTableSectionTest test cases which called a method on nil. In particular, section var was nil for the tests, which had document().body()->firstChild()->firstChild()->layoutObject()); These are switched to getLayoutObjectByElementId("section"), and also checks for section != NULL were added. The bug was found with running the test with UBSan. BUG=607996 ==========
On 2016/10/27 21:14:22, Xianzhu wrote: > lgtm. > > The failure is weird, but the new code looks better. > > Is there a bug of this? If not, please remove the BUG= line from description. There is a general bug to remove the existing UBSan failures, I have added it to the description. Thank you for the fast turnaround.
krasin@chromium.org changed reviewers: + dpranke@chromium.org
Hi Dirk, may I have your blessing for the //testing/buildbot/chromium.fyi.json changes? I have fixed all webkit_unit_tests cases under UBsan and want to put it on the on the bots. krasin
https://codereview.chromium.org/2455223002/diff/40001/testing/buildbot/chromi... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2455223002/diff/40001/testing/buildbot/chromi... testing/buildbot/chromium.fyi.json:4122: "test": "net_unittests" Are you intentionally adding net_unittests in this change? Your CL description doesn't mention it.
Description was changed from ========== Fix LayoutTableSectionTest test cases which called a method on nil. In particular, section var was nil for the tests, which had document().body()->firstChild()->firstChild()->layoutObject()); These are switched to getLayoutObjectByElementId("section"), and also checks for section != NULL were added. The bug was found with running the test with UBSan. BUG=607996 ========== to ========== Fix LayoutTableSectionTest test cases which called a method on nil. In particular, section var was nil for the tests, which had document().body()->firstChild()->firstChild()->layoutObject()); These are switched to getLayoutObjectByElementId("section"), and also checks for section != NULL were added. The bug was found with running the test with UBSan. Also adding net_unittests to UBSanVptr ToT, as it has already been runnin on the regular UBSanVptr bot. BUG=607996 ==========
On 2016/10/27 22:41:00, Dirk Pranke wrote: > https://codereview.chromium.org/2455223002/diff/40001/testing/buildbot/chromi... > File testing/buildbot/chromium.fyi.json (right): > > https://codereview.chromium.org/2455223002/diff/40001/testing/buildbot/chromi... > testing/buildbot/chromium.fyi.json:4122: "test": "net_unittests" > Are you intentionally adding net_unittests in this change? Your CL description > doesn't mention it. I have updated the description. I was going through the list of known problematic test suites (https://bugs.chromium.org/p/chromium/issues/detail?id=607996#c4) and realized that net_unittests is already added to UBsanVptr, but missing on it ToT counterpart. The diff is likely larger, but I am currently going one-by-one, and will fix it eventually.
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2455223002/diff/40001/testing/buildbot/chromi... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2455223002/diff/40001/testing/buildbot/chromi... testing/buildbot/chromium.fyi.json:4122: "test": "net_unittests" On 2016/10/27 22:40:59, Dirk Pranke wrote: > Are you intentionally adding net_unittests in this change? Your CL description > doesn't mention it. Replied out of line. TL;DR: yes, intentionally; description updated. Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ok, lgtm.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by krasin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org, dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2455223002/#ps80001 (title: "fix bad merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by krasin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix LayoutTableSectionTest test cases which called a method on nil. In particular, section var was nil for the tests, which had document().body()->firstChild()->firstChild()->layoutObject()); These are switched to getLayoutObjectByElementId("section"), and also checks for section != NULL were added. The bug was found with running the test with UBSan. Also adding net_unittests to UBSanVptr ToT, as it has already been runnin on the regular UBSanVptr bot. BUG=607996 ========== to ========== Fix LayoutTableSectionTest test cases which called a method on nil. In particular, section var was nil for the tests, which had document().body()->firstChild()->firstChild()->layoutObject()); These are switched to getLayoutObjectByElementId("section"), and also checks for section != NULL were added. The bug was found with running the test with UBSan. Also adding net_unittests to UBSanVptr ToT, as it has already been runnin on the regular UBSanVptr bot. BUG=607996 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Fix LayoutTableSectionTest test cases which called a method on nil. In particular, section var was nil for the tests, which had document().body()->firstChild()->firstChild()->layoutObject()); These are switched to getLayoutObjectByElementId("section"), and also checks for section != NULL were added. The bug was found with running the test with UBSan. Also adding net_unittests to UBSanVptr ToT, as it has already been runnin on the regular UBSanVptr bot. BUG=607996 ========== to ========== Fix LayoutTableSectionTest test cases which called a method on nil. In particular, section var was nil for the tests, which had document().body()->firstChild()->firstChild()->layoutObject()); These are switched to getLayoutObjectByElementId("section"), and also checks for section != NULL were added. The bug was found with running the test with UBSan. Also adding net_unittests to UBSanVptr ToT, as it has already been runnin on the regular UBSanVptr bot. BUG=607996 Committed: https://crrev.com/623cf72475439f27bdcb556616887366b7566094 Cr-Commit-Position: refs/heads/master@{#428259} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/623cf72475439f27bdcb556616887366b7566094 Cr-Commit-Position: refs/heads/master@{#428259} |