Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: appengine/findit/crash/results.py

Issue 2455053004: Moving ScheduleNewAnalysis to break the cycle (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/results.py
diff --git a/appengine/findit/crash/results.py b/appengine/findit/crash/results.py
index 728a68af205dcc5f0aded5a3eaded29cb29e7ca1..066941e37dc4530799bb025cb466c49b81894599 100644
--- a/appengine/findit/crash/results.py
+++ b/appengine/findit/crash/results.py
@@ -11,7 +11,7 @@ class AnalysisInfo(namedtuple('AnalysisInfo',
# TODO(http://crbug.com/644476): this class needs a better name.
-# TODO(wrengr): subclass namedtuple, so most things are immutable.
+# TODO(http://crbug.com/661822): convert this into a namedtuple.
class Result(object):
"""Represents findit culprit result."""
@@ -25,9 +25,8 @@ class Result(object):
# TODO(wrengr): (a) make these two fields private/readonly
# TODO(wrengr): (b) zip them together.
- # TODO(wrengr): replace "stack_info" pair with a namedtuple.
+ # TODO(http://crbug.com/661822): change stack_info pair to a namedtuple.
self.file_to_stack_infos = {}
- # TODO(wrengr): replace "analysis_info" dict with a namedtuple.
self.file_to_analysis_info = {}
def ToDict(self):

Powered by Google App Engine
This is Rietveld 408576698