Moving ScheduleNewAnalysis to break the cycle

appengine/findit/crash/results.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import namedtuple
 
 # TODO(http://crbug.com/644476): this class needs a better name.
 class AnalysisInfo(namedtuple('AnalysisInfo',
     ['min_distance', 'min_distance_frame'])):
   __slots__ = ()
 
 
 # TODO(http://crbug.com/644476): this class needs a better name.
-# TODO(wrengr): subclass namedtuple, so most things are immutable.
+# TODO(http://crbug.com/661822): convert this into a namedtuple.
 class Result(object):
   """Represents findit culprit result."""
 
   def __init__(self, changelog, dep_path,
                confidence=None, reasons=None, changed_files=None):
     self.changelog = changelog
     self.dep_path = dep_path
     self.confidence = confidence
     self.reasons = reasons
     self.changed_files = changed_files
 
     # TODO(wrengr): (a) make these two fields private/readonly
     # TODO(wrengr): (b) zip them together.
-    # TODO(wrengr): replace "stack_info" pair with a namedtuple.
+    # TODO(http://crbug.com/661822): change stack_info pair to a namedtuple.
     self.file_to_stack_infos = {}
-    # TODO(wrengr): replace "analysis_info" dict with a namedtuple.
     self.file_to_analysis_info = {}
 
   def ToDict(self):
     return {
         'url': self.changelog.commit_url,
         'review_url': self.changelog.code_review_url,
         'revision': self.changelog.revision,
         'project_path': self.dep_path,
         'author': self.changelog.author_email,
         'time': str(self.changelog.author_time),
@@ skipping 121 matching lines @@
     """
     for changelog in changelogs:
       if self._ignore_cls and changelog.revision in self._ignore_cls:
         continue
 
       if changelog.revision not in self:
         self[changelog.revision] = MatchResult(changelog, dep_path)
 
       match_result = self[changelog.revision]
       match_result.Update(file_path, stack_infos, blame)