Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2373)

Unified Diff: appengine/findit/lib/gitiles/change_log.py

Issue 2455053004: Moving ScheduleNewAnalysis to break the cycle (Closed)
Patch Set: rebase & adding some tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/lib/gitiles/change_log.py
diff --git a/appengine/findit/lib/gitiles/change_log.py b/appengine/findit/lib/gitiles/change_log.py
index c56c8ec6e20267b6a147e6fc598f6a70cebfe938..5969682f868914a86e75e2c81e85502343a17990 100644
--- a/appengine/findit/lib/gitiles/change_log.py
+++ b/appengine/findit/lib/gitiles/change_log.py
@@ -22,6 +22,7 @@ class FileChangeInfo(object):
info['change_type'], info['old_path'], info['new_path'])
+# TODO(wrengr); convert this into a namedtuple.
stgao 2016/11/02 01:28:27 I like this idea. Maybe do the same for FileChange
wrengr 2016/11/02 23:52:26 I filed a bug: http://crbug.com/661822. Feel free
stgao 2016/11/03 04:48:10 Thanks!
class ChangeLog(object):
"""Represents the change log of a revision."""

Powered by Google App Engine
This is Rietveld 408576698