Moving ScheduleNewAnalysis to break the cycle

appengine/findit/lib/gitiles/change_log.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 class FileChangeInfo(object):
   """Represents a file change (add/delete/modify/rename/copy/etc)."""
   def __init__(self, change_type, old_path, new_path):
     self.change_type = change_type
     self.old_path = old_path
     self.new_path = new_path
 
   def ToDict(self):
     return {
         'change_type': self.change_type,
         'old_path': self.old_path,
         'new_path': self.new_path
     }
 
   @staticmethod
   def FromDict(info):
     return FileChangeInfo(
         info['change_type'], info['old_path'], info['new_path'])
 
 
+# TODO(wrengr); convert this into a namedtuple.

[stgao, 2016/11/02 01:28:27]

I like this idea. Maybe do the same for FileChangeInfo above too.

[wrengr, 2016/11/02 23:52:26]

I filed a bug: http://crbug.com/661822. Feel free to add more things to the list
there, and I'll get to them sometime next week.

[stgao, 2016/11/03 04:48:10]

Thanks!

 class ChangeLog(object):
   """Represents the change log of a revision."""
 
   def __init__(self, author_name, author_email, author_time, committer_name,
                committer_email, committer_time, revision, commit_position,
                message, touched_files, commit_url, code_review_url=None,
                reverted_revision=None):
     self.author_name = author_name
     self.author_email = author_email
     self.author_time = author_time
@@ skipping 36 matching lines @@
     for touched_file_info in info['touched_files']:
       touched_files.append(FileChangeInfo.FromDict(touched_file_info))
 
     return ChangeLog(
         info['author_name'], info['author_email'], info['author_time'],
         info['committer_name'], info['committer_email'], info['committer_time'],
         info['revision'], info['commit_position'], info['message'],
         touched_files, info['commit_url'], info['code_review_url'],
         info['reverted_revision']
     )