Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2454923003: DO NOT COMMIT DevTools: minor cleanup for ConsoleViewMessage (Closed)

Created:
4 years, 1 month ago by luoe
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: minor cleanup for ConsoleViewMessage - table formatter will stay in CVM, so it should be using 'this.' - linkify-ing functions are inlined - _formatParameter() now gets 'showUndefinedsInArray', so we can pass something informative instead of 'messageType' later

Patch Set 1 #

Patch Set 2 : Simplify things #

Patch Set 3 : Simplify things #

Patch Set 4 : reintroduce this._message for builders #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -70 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 2 3 15 chunks +34 lines, -70 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (14 generated)
luoe
4 years, 1 month ago (2016-10-27 00:59:44 UTC) #4

          

Powered by Google App Engine
This is Rietveld 408576698