third_party/WebKit/Source/core/frame/VisualViewport.cpp - Issue 2454913003: MainFrame scrollbars should work with RFV instead of FV

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.cpp

Issue 2454913003: MainFrame scrollbars should work with RFV instead of FV (Closed)

Patch Set: Fix VisualViewportTest Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/VisualViewport.cpp

diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.cpp b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

index 7561c03b0fa49cf87afc275f79a099554c64e0d8..8514a0223f230d88487e6473fa2d8a8e72683295 100644

--- a/third_party/WebKit/Source/core/frame/VisualViewport.cpp

+++ b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

@@ -296,6 +296,10 @@ bool VisualViewport::didSetScaleOrLocation(float scale,

clampToBoundaries();

+ // TODO(ymalik): VisualViewport shouldn't be talking to FrameView and this

+ // should happen through RootFrameViewport.

+ mainFrame()->view()->updateScrollbars();

bokan 2016/11/03 19:59:59 We don't need this anymore since you added it to R

ymalik 2016/11/04 18:54:17 Oops, forgot to remove. Thanks.

return true;

}