Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2454913003: MainFrame scrollbars should work with RFV instead of FV (Closed)
Patch Set: Fix VisualViewportTest Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
index b5ff43d9e63497e3970144fc3f3c584c8fc61f91..9b32c7a62cc9b404ae8218ef9effca53512c4ae9 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
@@ -50,6 +50,7 @@
#include "core/dom/Node.h"
#include "core/dom/shadow/ShadowRoot.h"
#include "core/editing/FrameSelection.h"
+#include "core/editing/markers/DocumentMarkerController.h"
#include "core/frame/FrameHost.h"
#include "core/frame/FrameView.h"
#include "core/frame/LocalFrame.h"
@@ -670,6 +671,15 @@ void PaintLayerScrollableArea::updateScrollbarsEnabledState() {
}
}
+void PaintLayerScrollableArea::updateScrollbars() {
+ if (visualViewportSuppliesScrollbars())
+ return;
+
+ // TODO(crbug.com/661236): Refactor relevant bits from updateAfterLayout and
+ // call here.
+ updateAfterLayout();
+}
+
void PaintLayerScrollableArea::updateAfterLayout() {
DCHECK(box().hasOverflowClip());
@@ -1763,6 +1773,13 @@ PaintLayerScrollableArea::compositorAnimationTimeline() const {
return nullptr;
}
+void PaintLayerScrollableArea::getTickmarks(Vector<IntRect>& tickmarks) const {
+ if (LocalFrame* frame = box().frame()) {
+ tickmarks = frame->document()->markers().renderedRectsForMarkers(
bokan 2016/11/03 19:59:59 I think this should probably use the RFV markers i
ymalik 2016/11/04 18:54:18 See comment above. This is only called from RFV an
+ DocumentMarker::TextMatch);
+ }
+}
+
PaintLayerScrollableArea*
PaintLayerScrollableArea::ScrollbarManager::scrollableArea() {
return toPaintLayerScrollableArea(m_scrollableArea.get());

Powered by Google App Engine
This is Rietveld 408576698