Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2454843002: [Merge to M55] Optimize the table creation in the Sys Info page of the feedback app (Closed)

Created:
4 years, 1 month ago by afakhry
Modified:
4 years, 1 month ago
Reviewers:
xiyuan
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, apacible+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Merge to M55] Optimize the table creation in the Sys Info page of the feedback app Removes many bottle necks. Adds spinners to clearly show progress to the user. Builds the table incrementally to show incremental progress. TBR=xiyuan@chromium.org BUG=653968 TEST=manually CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2403503003 Cr-Commit-Position: refs/heads/master@{#424842} (cherry picked from commit 18870e37b4186d6d68529965cac48023436855ab) Committed: https://chromium.googlesource.com/chromium/src/+/cc3f19f73e42725b9c46224520854531020e671d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -81 lines) Patch
M chrome/browser/resources/about_sys/about_sys.css View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/resources/feedback/css/sys_info.css View 1 chunk +11 lines, -4 lines 0 comments Download
M chrome/browser/resources/feedback/html/sys_info.html View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/resources/feedback/js/feedback.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/feedback/js/sys_info.js View 6 chunks +130 lines, -63 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
afakhry
4 years, 1 month ago (2016-10-26 21:29:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc3f19f73e42725b9c46224520854531020e671d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698