Optimize the table creation in the Sys Info page of the feedback app

Optimize the table creation in the Sys Info page of the feedback app

Removes many bottle necks. Adds spinners to clearly show progress to
the user. Builds the table incrementally to show incremental progress.

BUG=653968
TEST=manually
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/18870e37b4186d6d68529965cac48023436855ab
Cr-Commit-Position: refs/heads/master@{#424842}

[afakhry, 2016-10-08 00:45:29]

Description was changed from

==========
Optimize the table creation in the Sys Info page of the feedback app

Removes many bottle necks. Adds spinners to clearly show progress to
the user. Builds the table incrementally to show incremental progress.

BUG=653968
TEST=manually
==========

to

==========
Optimize the table creation in the Sys Info page of the feedback app

Removes many bottle necks. Adds spinners to clearly show progress to
the user. Builds the table incrementally to show incremental progress.

BUG=653968
TEST=manually
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2016-10-08 00:50:10]

Patchset #1 (id:1) has been deleted

[afakhry, 2016-10-08 01:11:29]

afakhry@chromium.org changed reviewers:
+ xiyuan@chromium.org

[afakhry, 2016-10-08 01:11:30]

Xiyuan, please review. Thanks!

[xiyuan, 2016-10-10 16:57:36]

Just nits

https://codereview.chromium.org/2403503003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/feedback/html/sys_info.html (right):

https://codereview.chromium.org/2403503003/diff/20001/chrome/browser/resource...
chrome/browser/resources/feedback/html/sys_info.html:35: style="display:
inline-block;"></p>
Move the style to css.

https://codereview.chromium.org/2403503003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/feedback/js/sys_info.js (right):

https://codereview.chromium.org/2403503003/diff/20001/chrome/browser/resource...
chrome/browser/resources/feedback/js/sys_info.js:159:
$('detailsTable').appendChild(row);
nit: move appendChild into the wrapper function where createTableRow is called.

https://codereview.chromium.org/2403503003/diff/20001/chrome/browser/resource...
chrome/browser/resources/feedback/js/sys_info.js:189: setTimeout(processQueue,
STANDARD_DELAY_MS);
nit: move this into processQueue to keep scheduling related code together.

[afakhry, 2016-10-12 16:12:08]

https://codereview.chromium.org/2403503003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/feedback/html/sys_info.html (right):

https://codereview.chromium.org/2403503003/diff/20001/chrome/browser/resource...
chrome/browser/resources/feedback/html/sys_info.html:35: style="display:
inline-block;"></p>
On 2016/10/10 16:57:35, xiyuan wrote:
> Move the style to css.

Done. Moved all the styles here specific to sysinfo (not about_sys) to a
separate css file.

https://codereview.chromium.org/2403503003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/feedback/js/sys_info.js (right):

https://codereview.chromium.org/2403503003/diff/20001/chrome/browser/resource...
chrome/browser/resources/feedback/js/sys_info.js:159:
$('detailsTable').appendChild(row);
On 2016/10/10 16:57:35, xiyuan wrote:
> nit: move appendChild into the wrapper function where createTableRow is
called. 

Done.

https://codereview.chromium.org/2403503003/diff/20001/chrome/browser/resource...
chrome/browser/resources/feedback/js/sys_info.js:189: setTimeout(processQueue,
STANDARD_DELAY_MS);
On 2016/10/10 16:57:35, xiyuan wrote:
> nit: move this into processQueue to keep scheduling related code together.

Done.

[afakhry, 2016-10-12 16:12:25]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 16:12:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 16:17:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 16:17:57]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[xiyuan, 2016-10-12 16:26:03]

lgtm

https://codereview.chromium.org/2403503003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/feedback/html/sys_info.html (right):

https://codereview.chromium.org/2403503003/diff/20001/chrome/browser/resource...
chrome/browser/resources/feedback/html/sys_info.html:35: style="display:
inline-block;"></p>
On 2016/10/12 16:12:07, afakhry wrote:
> On 2016/10/10 16:57:35, xiyuan wrote:
> > Move the style to css.
> 
> Done. Moved all the styles here specific to sysinfo (not about_sys) to a
> separate css file.

Cool. Thanks.

[afakhry, 2016-10-12 17:09:03]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2016-10-12 17:09:03]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2403503003/#ps60001
(title: "Fix js styles for presubmit")

[commit-bot: I haz the power, 2016-10-12 17:09:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 17:18:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 17:18:17]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[afakhry, 2016-10-12 20:27:11]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2016-10-12 20:27:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 20:42:44]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-12 20:47:09]

Description was changed from

==========
Optimize the table creation in the Sys Info page of the feedback app

Removes many bottle necks. Adds spinners to clearly show progress to
the user. Builds the table incrementally to show incremental progress.

BUG=653968
TEST=manually
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Optimize the table creation in the Sys Info page of the feedback app

Removes many bottle necks. Adds spinners to clearly show progress to
the user. Builds the table incrementally to show incremental progress.

BUG=653968
TEST=manually
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/18870e37b4186d6d68529965cac48023436855ab
Cr-Commit-Position: refs/heads/master@{#424842}
==========

[commit-bot: I haz the power, 2016-10-12 20:47:10]

Patchset 3 (id:??) landed as
https://crrev.com/18870e37b4186d6d68529965cac48023436855ab
Cr-Commit-Position: refs/heads/master@{#424842}