Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: tools/perf/benchmarks/dom_perf.py

Issue 245473002: Get rid of page_set.FromDict from browsermark, canvasmark, dom_perf, html5gaming benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/canvasmark.py ('k') | tools/perf/benchmarks/html5gaming.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/dom_perf.py
diff --git a/tools/perf/benchmarks/dom_perf.py b/tools/perf/benchmarks/dom_perf.py
index d78bfd456093f21c494c9fc39b32d3e470b51a67..a20a2542ef4b7cef79a7ae55f97e7327e5d548a8 100644
--- a/tools/perf/benchmarks/dom_perf.py
+++ b/tools/perf/benchmarks/dom_perf.py
@@ -80,18 +80,20 @@ class DomPerf(test.Test):
def CreatePageSet(self, options):
dom_perf_dir = os.path.join(util.GetChromiumSrcDir(), 'data', 'dom_perf')
- base_page = 'file://run.html?reportInJS=1&run='
- return page_set.PageSet.FromDict({
- 'pages': [
- { 'url': base_page + 'Accessors' },
- { 'url': base_page + 'CloneNodes' },
- { 'url': base_page + 'CreateNodes' },
- { 'url': base_page + 'DOMDivWalk' },
- { 'url': base_page + 'DOMTable' },
- { 'url': base_page + 'DOMWalk' },
- { 'url': base_page + 'Events' },
- { 'url': base_page + 'Get+Elements' },
- { 'url': base_page + 'GridSort' },
- { 'url': base_page + 'Template' }
- ]
- }, dom_perf_dir)
+ run_params = [
+ 'Accessors',
+ 'CloneNodes',
+ 'CreateNodes',
+ 'DOMDivWalk',
+ 'DOMTable',
+ 'DOMWalk',
+ 'Events',
+ 'Get+Elements',
+ 'GridSort',
+ 'Template'
+ ]
+ ps = page_set.PageSet(file_path=dom_perf_dir)
+ for param in run_params:
+ ps.AddPageWithDefaultRunNavigate(
+ 'file://run.html?reportInJS=1&run=%s' % param)
+ return ps
« no previous file with comments | « tools/perf/benchmarks/canvasmark.py ('k') | tools/perf/benchmarks/html5gaming.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698