Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tools/perf/benchmarks/html5gaming.py

Issue 245473002: Get rid of page_set.FromDict from browsermark, canvasmark, dom_perf, html5gaming benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/dom_perf.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/html5gaming.py
diff --git a/tools/perf/benchmarks/html5gaming.py b/tools/perf/benchmarks/html5gaming.py
index 341d0cdb71e3b3c7e8827c8152f119bd3ff284da..98370b0c6ca418e110617c589df49430a72fe221 100644
--- a/tools/perf/benchmarks/html5gaming.py
+++ b/tools/perf/benchmarks/html5gaming.py
@@ -16,7 +16,6 @@ from telemetry import test
from telemetry.page import page_measurement
from telemetry.page import page_set
-
class _HTML5GamingMeasurement(page_measurement.PageMeasurement):
def MeasurePage(self, _, tab, results):
tab.ExecuteJavaScript('benchmark();')
@@ -33,12 +32,9 @@ class HTML5Gaming(test.Test):
"""Imapct HTML5 smooth running games benchmark suite."""
test = _HTML5GamingMeasurement
def CreatePageSet(self, options):
- return page_set.PageSet.FromDict({
- 'archive_data_file': '../page_sets/data/html5gaming.json',
- 'make_javascript_deterministic': False,
- 'pages': [
- { 'url':
- 'http://html5-benchmark.com/'}
- ]
- }, os.path.abspath(__file__))
-
+ ps = page_set.PageSet(
+ file_path=os.path.abspath(__file__),
+ archive_data_file='../page_sets/data/html5gaming.json',
+ make_javascript_deterministic=False)
+ ps.AddPageWithDefaultRunNavigate('http://html5-benchmark.com/')
+ return ps
« no previous file with comments | « tools/perf/benchmarks/dom_perf.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698