Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 245473002: Get rid of page_set.FromDict from browsermark, canvasmark, dom_perf, html5gaming benchmarks. (Closed)

Created:
6 years, 8 months ago by nednguyen
Modified:
6 years, 7 months ago
Reviewers:
tonyg, dtu, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Get rid of page_set.FromDict from browsermark, canvasmark, dom_perf, html5gaming benchmarks. BUG=239179 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266775

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -44 lines) Patch
M tools/perf/benchmarks/browsermark.py View 1 2 chunks +6 lines, -10 lines 0 comments Download
M tools/perf/benchmarks/canvasmark.py View 1 2 chunks +8 lines, -9 lines 0 comments Download
M tools/perf/benchmarks/dom_perf.py View 1 1 chunk +17 lines, -15 lines 0 comments Download
M tools/perf/benchmarks/html5gaming.py View 1 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
nednguyen
6 years, 8 months ago (2014-04-21 17:54:50 UTC) #1
nduca
lgtm
6 years, 8 months ago (2014-04-21 18:30:01 UTC) #2
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 8 months ago (2014-04-21 18:30:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/245473002/1
6 years, 8 months ago (2014-04-21 18:30:30 UTC) #4
nednguyen
The CQ bit was unchecked by nednguyen@google.com
6 years, 8 months ago (2014-04-21 18:43:39 UTC) #5
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-28 20:51:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/245473002/1
6 years, 7 months ago (2014-04-28 20:52:42 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 20:53:04 UTC) #8
commit-bot: I haz the power
Failed to apply patch for tools/telemetry/telemetry/page/page_set.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-04-28 20:53:05 UTC) #9
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-28 20:58:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/245473002/20001
6 years, 7 months ago (2014-04-28 20:58:35 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 21:43:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 21:43:33 UTC) #13
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-28 21:44:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/245473002/20001
6 years, 7 months ago (2014-04-28 21:45:11 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:27:06 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 22:27:07 UTC) #17
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-28 22:43:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/245473002/20001
6 years, 7 months ago (2014-04-28 22:44:07 UTC) #19
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 07:48:06 UTC) #20
Message was sent while issue was closed.
Change committed as 266775

Powered by Google App Engine
This is Rietveld 408576698