Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2454723002: Reland "[heap] Uncommit marking deque in concurrent task." (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz, ahaas
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Uncommit marking deque in concurrent task." This reverts commit 35e4a03f5b4f8dadd900b1eb118f028bb5dfe6ec. BUG= Committed: https://crrev.com/017f48d2213a7469caef33977aba020310facf21 Cr-Commit-Position: refs/heads/master@{#40614}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix ce #

Patch Set 4 : one more ce fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -16 lines) Patch
M src/cancelable-task.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/cancelable-task.cc View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M src/heap/mark-compact.h View 5 chunks +47 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 5 chunks +35 lines, -3 lines 0 comments Download
M src/heap/page-parallel-job.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/heap/test-mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
ulan
PTAL. The diff between PS1&2 contains the fix. Andreas, could you please take a look ...
4 years, 1 month ago (2016-10-26 14:42:33 UTC) #2
ahaas
On 2016/10/26 at 14:42:33, ulan wrote: > PTAL. The diff between PS1&2 contains the fix. ...
4 years, 1 month ago (2016-10-26 14:45:53 UTC) #3
Michael Lippautz
On 2016/10/26 14:45:53, ahaas wrote: > On 2016/10/26 at 14:42:33, ulan wrote: > > PTAL. ...
4 years, 1 month ago (2016-10-26 14:56:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454723002/60001
4 years, 1 month ago (2016-10-26 15:46:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/16903)
4 years, 1 month ago (2016-10-26 16:05:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454723002/60001
4 years, 1 month ago (2016-10-27 11:03:21 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-27 11:30:21 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:15:13 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/017f48d2213a7469caef33977aba020310facf21
Cr-Commit-Position: refs/heads/master@{#40614}

Powered by Google App Engine
This is Rietveld 408576698