src/heap/page-parallel-job.h - Issue 2454723002: Reland "[heap] Uncommit marking deque in concurrent task."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/page-parallel-job.h

Issue 2454723002: Reland "[heap] Uncommit marking deque in concurrent task." (Closed)

Patch Set: one more ce fix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/page-parallel-job.h

diff --git a/src/heap/page-parallel-job.h b/src/heap/page-parallel-job.h

index 440c440b7e7e0b9d8951cf2d91ba939021f6b713..ad1d9b3e301fd224ef6b10fc868408494dfcc572 100644

--- a/src/heap/page-parallel-job.h

+++ b/src/heap/page-parallel-job.h

@@ -103,7 +103,8 @@ class PageParallelJob {

delete main_task;

// Wait for background tasks.

for (int i = 0; i < num_tasks_; i++) {

- if (!cancelable_task_manager_->TryAbort(task_ids[i])) {

+ if (cancelable_task_manager_->TryAbort(task_ids[i]) !=

+ CancelableTaskManager::kTaskAborted) {

pending_tasks_->Wait();

}

« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/wasm/wasm-module.cc » ('j') | no next file with comments »