[wrapper-tracing] Fix tracing of EventTargetWithInlineData

[wrapper-tracing] Fix tracing of EventTargetWithInlineData

Properly forward to super classes in all subclasses inheriting from
EventTargetWithInlineData.

BUG=chromium:468240
R=haraken@chromium.org,hlopko@chromium.org

Committed: https://crrev.com/65bce3b797f3a35d732ffbb6ba820edc027c20c8
Cr-Commit-Position: refs/heads/master@{#427686}

[Michael Lippautz, 2016-10-26 11:42:53]

ptal

This is missing from the initial wrapper tracing implementation. Ideally, we
would have a plugin for this, but for the time being I am going through them
manually.

[haraken, 2016-10-26 11:44:37]

On 2016/10/26 11:42:53, Michael Lippautz wrote:
> ptal
> 
> This is missing from the initial wrapper tracing implementation. Ideally, we
> would have a plugin for this, but for the time being I am going through them
> manually.

Yeah, we should definitely have a plugin check for this.

LGTM.

[Michael Lippautz, 2016-10-26 11:44:50]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2016-10-26 11:45:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marcel Hlopko, 2016-10-26 11:48:11]

https://codereview.chromium.org/2454683002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/EventTarget.h (right):

https://codereview.chromium.org/2454683002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/EventTarget.h:232:
DEFINE_INLINE_VIRTUAL_TRACE_WRAPPERS() {
This is not needed, right?

https://codereview.chromium.org/2454683002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestEventTarget.h
(right):

https://codereview.chromium.org/2454683002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestEventTarget.h:51:
DEFINE_INLINE_VIRTUAL_TRACE_WRAPPERS() {
Also this shouldn't be needed...

[Michael Lippautz, 2016-10-26 11:51:01]

The CQ bit was unchecked by mlippautz@chromium.org

[Michael Lippautz, 2016-10-26 11:53:48]

You are right that they are not needed. Since we usually don't write them if the
base class will take care of the call I removed them for consistency.

https://codereview.chromium.org/2454683002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/EventTarget.h (right):

https://codereview.chromium.org/2454683002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/EventTarget.h:232:
DEFINE_INLINE_VIRTUAL_TRACE_WRAPPERS() {
On 2016/10/26 11:48:11, Marcel Hlopko wrote:
> This is not needed, right?

Done.

https://codereview.chromium.org/2454683002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestEventTarget.h
(right):

https://codereview.chromium.org/2454683002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestEventTarget.h:51:
DEFINE_INLINE_VIRTUAL_TRACE_WRAPPERS() {
On 2016/10/26 11:48:11, Marcel Hlopko wrote:
> Also this shouldn't be needed...

Done.

[Michael Lippautz, 2016-10-26 11:54:11]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-10-26 11:54:12]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2454683002/#ps20001
(title: "Addressd comments")

[commit-bot: I haz the power, 2016-10-26 11:54:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 14:31:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-26 14:33:03]

Description was changed from

==========
[wrapper-tracing] Fix tracing of EventTargetWithInlineData

Properly forward to super classes in all subclasses inheriting from
EventTargetWithInlineData.

BUG=chromium:468240
R=haraken@chromium.org,hlopko@chromium.org
==========

to

==========
[wrapper-tracing] Fix tracing of EventTargetWithInlineData

Properly forward to super classes in all subclasses inheriting from
EventTargetWithInlineData.

BUG=chromium:468240
R=haraken@chromium.org,hlopko@chromium.org

Committed: https://crrev.com/65bce3b797f3a35d732ffbb6ba820edc027c20c8
Cr-Commit-Position: refs/heads/master@{#427686}
==========

[commit-bot: I haz the power, 2016-10-26 14:33:04]

Patchset 2 (id:??) landed as
https://crrev.com/65bce3b797f3a35d732ffbb6ba820edc027c20c8
Cr-Commit-Position: refs/heads/master@{#427686}