Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: third_party/WebKit/Source/core/events/EventTarget.h

Issue 2454683002: [wrapper-tracing] Fix tracing of EventTargetWithInlineData (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 6 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
7 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org> 7 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 class GC_PLUGIN_IGNORE("513199") CORE_EXPORT EventTargetWithInlineData 222 class GC_PLUGIN_IGNORE("513199") CORE_EXPORT EventTargetWithInlineData
223 : public EventTarget { 223 : public EventTarget {
224 public: 224 public:
225 ~EventTargetWithInlineData() override {} 225 ~EventTargetWithInlineData() override {}
226 226
227 DEFINE_INLINE_VIRTUAL_TRACE() { 227 DEFINE_INLINE_VIRTUAL_TRACE() {
228 visitor->trace(m_eventTargetData); 228 visitor->trace(m_eventTargetData);
229 EventTarget::trace(visitor); 229 EventTarget::trace(visitor);
230 } 230 }
231 231
232 DEFINE_INLINE_VIRTUAL_TRACE_WRAPPERS() {
Marcel Hlopko 2016/10/26 11:48:11 This is not needed, right?
Michael Lippautz 2016/10/26 11:53:48 Done.
233 EventTarget::traceWrappers(visitor);
234 }
235
232 protected: 236 protected:
233 EventTargetData* eventTargetData() final { return &m_eventTargetData; } 237 EventTargetData* eventTargetData() final { return &m_eventTargetData; }
234 EventTargetData& ensureEventTargetData() final { return m_eventTargetData; } 238 EventTargetData& ensureEventTargetData() final { return m_eventTargetData; }
235 239
236 private: 240 private:
237 EventTargetData m_eventTargetData; 241 EventTargetData m_eventTargetData;
238 }; 242 };
239 243
240 // FIXME: These macros should be split into separate DEFINE and DECLARE 244 // FIXME: These macros should be split into separate DEFINE and DECLARE
241 // macros to avoid causing so many header includes. 245 // macros to avoid causing so many header includes.
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 const AtomicString& eventType) { 322 const AtomicString& eventType) {
319 EventTargetData* d = eventTargetData(); 323 EventTargetData* d = eventTargetData();
320 if (!d) 324 if (!d)
321 return false; 325 return false;
322 return d->eventListenerMap.containsCapturing(eventType); 326 return d->eventListenerMap.containsCapturing(eventType);
323 } 327 }
324 328
325 } // namespace blink 329 } // namespace blink
326 330
327 #endif // EventTarget_h 331 #endif // EventTarget_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698