Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2454583002: Update the default generic font family settings for Chinese/Japanese (Closed)

Created:
4 years, 1 month ago by kojii
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the default generic font family settings for Chinese/Japanese This patch updates the default generic font family settings for Chinese and Japanese. Win Japanese standard/sans-serif Changed to Meiryo if available[1]. It was once Meiryo, but crbug.com/506837 changed to Yu Gothic because Meiryo is not available on non-Japanese versions of Win10. Meiryo is preferred when available because its rendering quality is better than Yu Gothic at this point. Win Japanese serif Changed to Yu Mincho if available[1]. Also added Times New Roman as fallback, since neither Yu Mincho nor MS PMincho are available on non-Japanese versions of Win10. Win Chinese cursive Changed to Kaiti/DFKai-SB (SC/TC.) Mac Chinese standard/sans-serif Changed to PingFang SC/TC if available[1]. These fonts are available since 10.11. Mac Chinese cursive Changed to Kaiti SC/TC. These are fonts available since 10.8/10.9. [1] The first-available-font-list was added in crbug.com/658646 BUG=579842, 506837, 592199, 587072, 648256 Committed: https://crrev.com/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d Cr-Commit-Position: refs/heads/master@{#429366}

Patch Set 1 #

Patch Set 2 : Add xtb #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : #

Patch Set 6 : SC/TC Cursive applied to xtb #

Patch Set 7 : Fix cursive on Mac #

Total comments: 4

Patch Set 8 : Remove Times New Roman #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -94 lines) Patch
M chrome/app/resources/locale_settings_mac.grd View 1 2 3 4 5 6 3 chunks +16 lines, -4 lines 0 comments Download
M chrome/app/resources/locale_settings_win.grd View 1 2 3 4 5 6 7 4 chunks +15 lines, -15 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_mac_zh-CN.xtb View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_mac_zh-TW.xtb View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 2 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_win_zh-CN.xtb View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/app/resources/platform_locale_settings/locale_settings_win_zh-TW.xtb View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 2 3 4 2 chunks +63 lines, -66 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 47 (35 generated)
kojii
PTAL. battre@: prefs_tab_helper.cc jshin@: all clang-format decided to re-format the whole array for prefs_tab_helper.cc, but ...
4 years, 1 month ago (2016-10-31 15:20:14 UTC) #30
jungshik at Google
https://codereview.chromium.org/2454583002/diff/120001/chrome/app/resources/locale_settings_win.grd File chrome/app/resources/locale_settings_win.grd (right): https://codereview.chromium.org/2454583002/diff/120001/chrome/app/resources/locale_settings_win.grd#newcode235 chrome/app/resources/locale_settings_win.grd:235: ,Yu Mincho,MS PMincho,Times New Roman What's the point of ...
4 years, 1 month ago (2016-11-01 00:12:02 UTC) #31
kojii
https://codereview.chromium.org/2454583002/diff/120001/chrome/app/resources/locale_settings_win.grd File chrome/app/resources/locale_settings_win.grd (right): https://codereview.chromium.org/2454583002/diff/120001/chrome/app/resources/locale_settings_win.grd#newcode235 chrome/app/resources/locale_settings_win.grd:235: ,Yu Mincho,MS PMincho,Times New Roman On 2016/11/01 at 00:12:02, ...
4 years, 1 month ago (2016-11-01 02:35:23 UTC) #32
jungshik at Google
On 2016/11/01 02:35:23, kojii wrote: > https://codereview.chromium.org/2454583002/diff/120001/chrome/app/resources/locale_settings_win.grd > File chrome/app/resources/locale_settings_win.grd (right): > > https://codereview.chromium.org/2454583002/diff/120001/chrome/app/resources/locale_settings_win.grd#newcode235 > ...
4 years, 1 month ago (2016-11-01 18:50:38 UTC) #33
kojii
On 2016/11/01 at 18:50:38, jshin wrote: > On 2016/11/01 02:35:23, kojii wrote: > > https://codereview.chromium.org/2454583002/diff/120001/chrome/app/resources/locale_settings_win.grd ...
4 years, 1 month ago (2016-11-02 01:27:49 UTC) #34
kojii
jshin@ PTAL, removed Times New Roman. battre@ PTAL for prefs_tab_helper.cc. I'll not land until jshin@ ...
4 years, 1 month ago (2016-11-02 01:33:08 UTC) #37
battre
lgtm
4 years, 1 month ago (2016-11-02 09:50:39 UTC) #40
jungshik at Google
LGTM https://codereview.chromium.org/2454583002/diff/140001/chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb File chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb (right): https://codereview.chromium.org/2454583002/diff/140001/chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb#newcode6 chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb:6: <translation id="IDS_SERIF_FONT_FAMILY">,Yu Mincho,MS PMincho</translation> I'd append "Meiryo,Yu Gothic" ...
4 years, 1 month ago (2016-11-02 18:10:11 UTC) #41
kojii
Thank you for your review. https://codereview.chromium.org/2454583002/diff/140001/chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb File chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb (right): https://codereview.chromium.org/2454583002/diff/140001/chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb#newcode6 chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb:6: <translation id="IDS_SERIF_FONT_FAMILY">,Yu Mincho,MS PMincho</translation> ...
4 years, 1 month ago (2016-11-02 19:27:12 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454583002/140001
4 years, 1 month ago (2016-11-02 19:28:07 UTC) #44
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 1 month ago (2016-11-02 19:36:57 UTC) #45
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 19:55:24 UTC) #47
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/0a4a11b1cfe0a7122fb0120672cce84e2bd78c6d
Cr-Commit-Position: refs/heads/master@{#429366}

Powered by Google App Engine
This is Rietveld 408576698