chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb - Issue 2454583002: Update the default generic font family settings for Chinese/Japanese

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/resources/platform_locale_settings/locale_settings_win_ja.xtb

Issue 2454583002: Update the default generic font family settings for Chinese/Japanese (Closed)

Patch Set: Remove Times New Roman Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/app/resources/platform_locale_settings/locale_settings_mac_zh-TW.xtb ('k') | chrome/app/resources/platform_locale_settings/locale_settings_win_zh-CN.xtb » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" ?>	1 <?xml version="1.0" ?>

2 <!DOCTYPE translationbundle>	2 <!DOCTYPE translationbundle>

3 <translationbundle lang="ja">	3 <translationbundle lang="ja">

4 <translation id="IDS_STANDARD_FONT_FAMILY">MS PGothic</translation>	4 <translation id="IDS_STANDARD_FONT_FAMILY">,Meiryo,Yu Gothic</translation>

5 <translation id="IDS_FIXED_FONT_FAMILY">MS Gothic</translation>	5 <translation id="IDS_FIXED_FONT_FAMILY">MS Gothic</translation>

6 <translation id="IDS_SERIF_FONT_FAMILY">MS PMincho</translation>	6 <translation id="IDS_SERIF_FONT_FAMILY">,Yu Mincho,MS PMincho</translation>
	jungshik at Google 2016/11/02 18:10:11 I'd append "Meiryo,Yu Gothic" to the end to preven I'd append "Meiryo,Yu Gothic" to the end to prevent a font fallback from picking up a non-Japanese font (e.g. Hans or Korean font). This has to be done to other generic family for which the presence of the font listed is not guaranteed. Aha... I think our font fallback already takes into account UI language to prioritize the font suitable for the UI language. In that case, this won't be necessary. kojii 2016/11/02 19:27:12 Right, we do. We use first-CJK lang of lang, accep Show quoted text On 2016/11/02 at 18:10:11, jungshik at google wrote: > I'd append "Meiryo,Yu Gothic" to the end to prevent a font fallback from picking up a non-Japanese font (e.g. Hans or Korean font). This has to be done to other generic family for which the presence of the font listed is not guaranteed. > Aha... I think our font fallback already takes into account UI language to prioritize the font suitable for the UI language. In that case, this won't be necessary. Right, we do. We use first-CJK lang of lang, accept-lang, UI lang to disambiguate unified Han.
7 <translation id="IDS_SANS_SERIF_FONT_FAMILY">MS PGothic</translation>	7 <translation id="IDS_SANS_SERIF_FONT_FAMILY">,Meiryo,Yu Gothic</translation>

8 <translation id="IDS_MINIMUM_FONT_SIZE">10</translation>	8 <translation id="IDS_MINIMUM_FONT_SIZE">10</translation>

9 <translation id="IDS_MINIMUM_LOGICAL_FONT_SIZE">10</translation>	9 <translation id="IDS_MINIMUM_LOGICAL_FONT_SIZE">10</translation>

10 </translationbundle>	10 </translationbundle>

OLD	NEW