[Payments] Update expired card expiration after unmask.

[Payments] Update expired card expiration after unmask.

BUG=656981
Committed: https://crrev.com/375feee956b0d11d7dde9ac01b722254c0c7850b
Cr-Commit-Position: refs/heads/master@{#428125}

[sebsg, 2016-10-25 22:42:54]

Patchset #2 (id:20001) has been deleted

[sebsg, 2016-10-25 22:43:04]

Patchset #1 (id:1) has been deleted

[sebsg, 2016-10-26 00:23:30]

Patchset #1 (id:40001) has been deleted

[sebsg, 2016-10-26 00:33:30]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 00:34:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2016-10-26 00:58:22]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-10-26 01:03:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 01:03:06]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sebsg, 2016-10-26 14:17:17]

Patchset #1 (id:80001) has been deleted

[sebsg, 2016-10-26 14:17:32]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 14:17:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2016-10-26 14:26:12]

sebsg@chromium.org changed reviewers:
+ rouslan@chromium.org

[sebsg, 2016-10-26 14:26:13]

Hi Rouslan, ptal?

[please use gerrit instead, 2016-10-26 15:23:04]

https://codereview.chromium.org/2454453002/diff/100001/components/autofill/co...
File components/autofill/core/browser/payments/full_card_request.cc (right):

https://codereview.chromium.org/2454453002/diff/100001/components/autofill/co...
components/autofill/core/browser/payments/full_card_request.cc:71: //
TODO(crbug.com/656981): Update the credit card expiration on file.
Remove the todo

https://codereview.chromium.org/2454453002/diff/100001/components/autofill/co...
components/autofill/core/browser/payments/full_card_request.cc:88:
personal_data_manager_->UpdateCreditCard(*credit_card);
Can we update the cache inside of UpdateCreditCard() instead of calling
GetCreditCardByGUID()?

[commit-bot: I haz the power, 2016-10-26 15:51:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 15:51:55]

Dry run: This issue passed the CQ dry run.

[sebsg, 2016-10-26 16:47:54]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 16:48:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2016-10-26 17:17:32]

Yep, that's way cleaner. Thanks!

https://codereview.chromium.org/2454453002/diff/100001/components/autofill/co...
File components/autofill/core/browser/payments/full_card_request.cc (right):

https://codereview.chromium.org/2454453002/diff/100001/components/autofill/co...
components/autofill/core/browser/payments/full_card_request.cc:71: //
TODO(crbug.com/656981): Update the credit card expiration on file.
On 2016/10/26 15:23:04, rouslan wrote:
> Remove the todo

Done.

https://codereview.chromium.org/2454453002/diff/100001/components/autofill/co...
components/autofill/core/browser/payments/full_card_request.cc:88:
personal_data_manager_->UpdateCreditCard(*credit_card);
On 2016/10/26 15:23:04, rouslan wrote:
> Can we update the cache inside of UpdateCreditCard() instead of calling
> GetCreditCardByGUID()?

Done.

[please use gerrit instead, 2016-10-26 17:20:57]

lgtm

[sebsg, 2016-10-26 17:40:36]

sebsg@chromium.org changed reviewers:
+ dfalcantara@chromium.org, mathp@chromium.org

[sebsg, 2016-10-26 17:40:37]

mathp@chromium.org: Could you please review C++ files?

dfalcantara@chromium.org: Could you please review Java files?

Thanks!

[Mathieu, 2016-10-26 17:57:08]

Neat, is it feasible to test to guard against future regressions
(personal_data_manager_unittest)?

[commit-bot: I haz the power, 2016-10-26 18:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 18:37:14]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2016-10-26 18:59:11]

Per offline conversation very hard to test this race condition, so lgtm

[gone, 2016-10-27 17:44:49]

lgtm

[sebsg, 2016-10-27 17:46:10]

The CQ bit was checked by sebsg@chromium.org

[commit-bot: I haz the power, 2016-10-27 17:46:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 19:06:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 19:06:44]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sebsg, 2016-10-27 19:35:39]

The CQ bit was checked by sebsg@chromium.org

[commit-bot: I haz the power, 2016-10-27 19:36:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 20:29:45]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-10-27 20:32:21]

Description was changed from

==========
[Payments] Update expired card expiration after unmask.

BUG=656981
==========

to

==========
[Payments] Update expired card expiration after unmask.

BUG=656981

Committed: https://crrev.com/375feee956b0d11d7dde9ac01b722254c0c7850b
Cr-Commit-Position: refs/heads/master@{#428125}
==========

[commit-bot: I haz the power, 2016-10-27 20:32:23]

Patchset 2 (id:??) landed as
https://crrev.com/375feee956b0d11d7dde9ac01b722254c0c7850b
Cr-Commit-Position: refs/heads/master@{#428125}