Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4038)

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.cc

Issue 2454453002: [Payments] Update expired card expiration after unmask. (Closed)
Patch Set: Addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/android/personal_data_manager_android.cc
diff --git a/chrome/browser/autofill/android/personal_data_manager_android.cc b/chrome/browser/autofill/android/personal_data_manager_android.cc
index 95d8ac67491b49c0c3f02b47a8806c061dc9e3b4..92fac1e7ce28ec55352a66734eba19a96eca3635 100644
--- a/chrome/browser/autofill/android/personal_data_manager_android.cc
+++ b/chrome/browser/autofill/android/personal_data_manager_android.cc
@@ -181,6 +181,13 @@ void PopulateNativeCreditCardFromJava(
card->set_server_id(
ConvertJavaStringToUTF8(Java_CreditCard_getServerId(env, jcard)));
+ // Only set the guid if it is an existing card (java guid not empty).
+ // Otherwise, keep the generated one.
+ std::string guid =
+ ConvertJavaStringToUTF8(Java_CreditCard_getGUID(env, jcard));
+ if (!guid.empty())
+ card->set_guid(guid);
+
if (Java_CreditCard_getIsLocal(env, jcard)) {
card->set_record_type(CreditCard::LOCAL_CARD);
} else {

Powered by Google App Engine
This is Rietveld 408576698