Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2454443002: Start action mode even if clipboard is empty (Closed)

Created:
4 years, 1 month ago by aelias_OOO_until_Jul13
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Start action mode even if clipboard is empty Previously clank would not call View#startActionMode for a FloatingPastePopup menu if the copy/paste clipboard was empty (because there would be nothing in the menu). This is a problem because apps using WebView may want to add items to the FloatingPastePopup menu (using startActionMode) even if the clipboard is empty. This patch makes clank call View#startActionMode and make an empty menu when there is nothing to paste. BUG=652916 Review-Url: https://codereview.chromium.org/2443963003 Cr-Commit-Position: refs/heads/master@{#427210} (cherry picked from commit 31c0e1a63f0a1a09374d0c2eb441286a532789e5) Committed: https://chromium.googlesource.com/chromium/src/+/6e75c14dbaacd7cafcb9a80f0aef1d942da19875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_OOO_until_Jul13
4 years, 1 month ago (2016-10-25 19:42:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6e75c14dbaacd7cafcb9a80f0aef1d942da19875.

Powered by Google App Engine
This is Rietveld 408576698