content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2454443002: Start action mode even if clipboard is empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2454443002: Start action mode even if clipboard is empty (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 22a40ef8a61ba940fe4bd7d8b1820721215707d3..65be3a3da26615b2c5e01dfa0affe1476a3f0645 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -2534,7 +2534,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

return;

}

- if (!mHasInsertion || !canPaste()) return;

+ if (!mHasInsertion || (!supportsFloatingActionMode() && !canPaste())) return;

PastePopupMenu pastePopupMenu = getPastePopup();

if (pastePopupMenu == null) return;

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/WebActionModeCallback.java » ('j') | no next file with comments »