Update platform_app.js to work even if window.history is not replaceable

Update platform_app.js to work even if window.history is not replaceable

platform_app.js was using "history = {};" to disable the History API. However,
Blink is about to be updated so that window.history is no longer replaceable
(as per the specification, and to align with other browsers). This CL updates
platform_app.js so that history is still disabled, even if window.history is
not replaceable.

BUG=365355
TEST=PlatformAppBrowserTest.Restrictions

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265429

[Inactive, 2014-04-21 19:46:10]

https://codereview.chromium.org/245443003/diff/1/chrome/test/data/extensions/...
File chrome/test/data/extensions/platform_apps/restrictions/main.js (right):

https://codereview.chromium.org/245443003/diff/1/chrome/test/data/extensions/...
chrome/test/data/extensions/platform_apps/restrictions/main.js:68:
assertEq('undefined', typeof(history[property]));
This is a bit safer now, in case new properties / methods are added to History
but we don't explicitly disable them in platform_app.js (as we now have to
disable / remove API explicitly).

Also, this adds coverage for history.go(), which was not tested before but
should be disabled.

[Inactive, 2014-04-22 13:15:35]

The Blink side change is at https://codereview.chromium.org/242613009/

It was reverted once for breaking the PlatformAppBrowserTest.Restrictions
browser test:
http://src.chromium.org/viewvc/blink?view=revision&revision=172014

I verified that the PlatformAppBrowserTest.Restrictions browser test is passing
with both patches applied.

[arv (Not doing code reviews), 2014-04-22 13:54:42]

https://codereview.chromium.org/245443003/diff/1/chrome/renderer/resources/ex...
File chrome/renderer/resources/extensions/platform_app.js (left):

https://codereview.chromium.org/245443003/diff/1/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/platform_app.js:155: window.history = {};
This one could have been replaced with a defineProperty instead.

[Inactive, 2014-04-22 14:43:53]

https://codereview.chromium.org/245443003/diff/1/chrome/renderer/resources/ex...
File chrome/renderer/resources/extensions/platform_app.js (left):

https://codereview.chromium.org/245443003/diff/1/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/platform_app.js:155: window.history = {};
On 2014/04/22 13:54:42, arv wrote:
> This one could have been replaced with a defineProperty instead.

Would be much simpler, let me give this a try.

[Inactive, 2014-04-22 14:59:58]

https://codereview.chromium.org/245443003/diff/1/chrome/renderer/resources/ex...
File chrome/renderer/resources/extensions/platform_app.js (left):

https://codereview.chromium.org/245443003/diff/1/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/platform_app.js:155: window.history = {};
On 2014/04/22 13:54:42, arv wrote:
> This one could have been replaced with a defineProperty instead.

Done, thanks. Much simpler indeed.

[arv (Not doing code reviews), 2014-04-22 15:03:32]

LGTM but please wait for one of the platform app people to review too.

[miket_OOO, 2014-04-22 19:37:21]

lgtm

[Inactive, 2014-04-22 19:38:48]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-04-22 19:39:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/245443003/20001

[commit-bot: I haz the power, 2014-04-23 00:02:23]

Change committed as 265429

[arv (Not doing code reviews), 2014-04-23 13:46:38]

I  just wanted to make you aware that these accessors should go on
History.prototype and once we fix bug
https://code.google.com/p/chromium/issues/detail?id=43394 we need to update this
to delete the accessors from the prototype too.