chrome/renderer/resources/extensions/platform_app.js - Issue 245443003: Update platform_app.js to work even if window.history is not replaceable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/platform_app.js

Issue 245443003: Update platform_app.js to work even if window.history is not replaceable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Take arv's feedback into consideration Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/extensions/platform_app.js

diff --git a/chrome/renderer/resources/extensions/platform_app.js b/chrome/renderer/resources/extensions/platform_app.js

index 0982a6a18ea0b4371208292f1fd14f6ed4d3b921..f6934cf0bf94d84d625f989b1bd535794f5160d9 100644

--- a/chrome/renderer/resources/extensions/platform_app.js

+++ b/chrome/renderer/resources/extensions/platform_app.js

@@ -152,7 +152,7 @@ disableMethods(HTMLDocument.prototype, 'document', ['open', 'clear', 'close']);

disableMethods(HTMLDocument.prototype, 'document', ['write', 'writeln'], true);

// Disable history.

-window.history = {};

+Object.defineProperty(window, "history", { value: {} });

disableGetters(window.history, 'history', ['back', 'forward', 'go', 'length']);

// Disable find.

« no previous file with comments | « no previous file | chrome/test/data/extensions/platform_apps/restrictions/main.js » ('j') | no next file with comments »