Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2454383002:
webgl, cmaa: choose immutable texture instead of BGRA support for WebGL1 (Closed)
Descriptionwebgl, cmaa: choose immutable texture instead of BGRA support for WebGL1
Rationale
* WebGL1 API needs neither immutable texture nor BGRA.
* WebGL1 implementation doesn't need BGRA
* WebGL1 implementation needs immutable texture for CMAA.
CMAA prefers RGBA8 as input. If RGBA is input, CMAA impl has to copy. It's why
WebGL allocates immutable texture as default FBO if possible.
BUG=535198
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/03f407d98f729b83f76b18fb5497abfc55abe5c5
Cr-Commit-Position: refs/heads/master@{#428446}
Patch Set 1 #Patch Set 2 : remove unnecessary change #Messages
Total messages: 19 (12 generated)
Description was changed from ========== webgl, cmaa: choose immutable texture instead of BGRA support for WebGL1 Rationale * WebGL1 API needs neither immutable texture nor BGRA. * WebGL1 implementation doesn't need BGRA * WebGL1 implementation needs immutable texture for CMAA. CMAA prefers RGBA8 as input. If RGBA is input, CMAA impl has to copy. It's why WebGL allocates immutable texture as default FBO if possible. BUG=535198 ========== to ========== webgl, cmaa: choose immutable texture instead of BGRA support for WebGL1 Rationale * WebGL1 API needs neither immutable texture nor BGRA. * WebGL1 implementation doesn't need BGRA * WebGL1 implementation needs immutable texture for CMAA. CMAA prefers RGBA8 as input. If RGBA is input, CMAA impl has to copy. It's why WebGL allocates immutable texture as default FBO if possible. BUG=535198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
piman@, could you review? It optimizes WebGL on Chromebook alot. It's kind of following CL of yours https://codereview.chromium.org/2000923002
Description was changed from ========== webgl, cmaa: choose immutable texture instead of BGRA support for WebGL1 Rationale * WebGL1 API needs neither immutable texture nor BGRA. * WebGL1 implementation doesn't need BGRA * WebGL1 implementation needs immutable texture for CMAA. CMAA prefers RGBA8 as input. If RGBA is input, CMAA impl has to copy. It's why WebGL allocates immutable texture as default FBO if possible. BUG=535198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== webgl, cmaa: choose immutable texture instead of BGRA support for WebGL1 Rationale * WebGL1 API needs neither immutable texture nor BGRA. * WebGL1 implementation doesn't need BGRA * WebGL1 implementation needs immutable texture for CMAA. CMAA prefers RGBA8 as input. If RGBA is input, CMAA impl has to copy. It's why WebGL allocates immutable texture as default FBO if possible. BUG=535198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
dongseong.hwang@intel.com changed reviewers: + piman@chromium.org
piman@, could you review? It optimizes WebGL on Chromebook alot. It's kind of following CL of yours https://codereview.chromium.org/2000923002
The CQ bit was checked by dongseong.hwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
On 2016/10/28 16:37:29, piman wrote: > lgtm thx for review!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dongseong.hwang@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== webgl, cmaa: choose immutable texture instead of BGRA support for WebGL1 Rationale * WebGL1 API needs neither immutable texture nor BGRA. * WebGL1 implementation doesn't need BGRA * WebGL1 implementation needs immutable texture for CMAA. CMAA prefers RGBA8 as input. If RGBA is input, CMAA impl has to copy. It's why WebGL allocates immutable texture as default FBO if possible. BUG=535198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== webgl, cmaa: choose immutable texture instead of BGRA support for WebGL1 Rationale * WebGL1 API needs neither immutable texture nor BGRA. * WebGL1 implementation doesn't need BGRA * WebGL1 implementation needs immutable texture for CMAA. CMAA prefers RGBA8 as input. If RGBA is input, CMAA impl has to copy. It's why WebGL allocates immutable texture as default FBO if possible. BUG=535198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== webgl, cmaa: choose immutable texture instead of BGRA support for WebGL1 Rationale * WebGL1 API needs neither immutable texture nor BGRA. * WebGL1 implementation doesn't need BGRA * WebGL1 implementation needs immutable texture for CMAA. CMAA prefers RGBA8 as input. If RGBA is input, CMAA impl has to copy. It's why WebGL allocates immutable texture as default FBO if possible. BUG=535198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== webgl, cmaa: choose immutable texture instead of BGRA support for WebGL1 Rationale * WebGL1 API needs neither immutable texture nor BGRA. * WebGL1 implementation doesn't need BGRA * WebGL1 implementation needs immutable texture for CMAA. CMAA prefers RGBA8 as input. If RGBA is input, CMAA impl has to copy. It's why WebGL allocates immutable texture as default FBO if possible. BUG=535198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/03f407d98f729b83f76b18fb5497abfc55abe5c5 Cr-Commit-Position: refs/heads/master@{#428446} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/03f407d98f729b83f76b18fb5497abfc55abe5c5 Cr-Commit-Position: refs/heads/master@{#428446} |
