Only allow TexStorage2DEXT if we expose the extension

Only allow TexStorage2DEXT if we expose the extension

If the underlying driver doesn't support the necessary extensions, TexStorageImpl crashes.
Also, make sure we enable the extension on es3 command buffers (and thus, possibly disable BGRA if it is not compatible).

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a756b558c63783ad5d94f805720a772df7357c7d
Cr-Commit-Position: refs/heads/master@{#395466}

[piman, 2016-05-21 01:24:03]

Description was changed from

==========
Only allow TexStorage2DEXT if we expose the extension

If the underlying driver doesn't support the necessary extensions,
TexStorageImpl crashes.

BUG=None
==========

to

==========
Only allow TexStorage2DEXT if we expose the extension

If the underlying driver doesn't support the necessary extensions,
TexStorageImpl crashes.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-05-23 20:33:45]

Patchset #1 (id:1) has been deleted

[piman, 2016-05-23 20:34:55]

Description was changed from

==========
Only allow TexStorage2DEXT if we expose the extension

If the underlying driver doesn't support the necessary extensions,
TexStorageImpl crashes.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Only allow TexStorage2DEXT if we expose the extension

If the underlying driver doesn't support the necessary extensions,
TexStorageImpl crashes.
Also, make sure we enable the extension on es3 command buffers (and thus,
possibly disable BGRA if it is not compatible).

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-05-23 20:35:18]

piman@chromium.org changed reviewers:
+ zmo@chromium.org

[Zhenyao Mo, 2016-05-23 21:22:37]

lgtm

https://codereview.chromium.org/2000923002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2000923002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:581:
!workarounds_.disable_texture_storage &&
disable_texture_storage should not apply to ES3/WebGL2 context.

So far we only apply it to older mesa, so the right decision should be disabling
ES3/WebGL2 entirely, or workaround the bug.

Could you add to TODO because this seems to be out of scope for this CL?

[piman, 2016-05-23 22:10:48]

https://codereview.chromium.org/2000923002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2000923002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:581:
!workarounds_.disable_texture_storage &&
On 2016/05/23 21:22:37, Zhenyao Mo wrote:
> disable_texture_storage should not apply to ES3/WebGL2 context.
> 
> So far we only apply it to older mesa, so the right decision should be
disabling
> ES3/WebGL2 entirely, or workaround the bug.
> 
> Could you add to TODO because this seems to be out of scope for this CL?

Good point. I actually fixed it by disabling ES3 in this CL, which seems easy
enough, and the right thing to do.

[piman, 2016-05-23 22:10:54]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-23 22:11:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000923002/40001

[piman, 2016-05-23 23:20:12]

The CQ bit was unchecked by piman@chromium.org

[piman, 2016-05-23 23:20:14]

The CQ bit was checked by piman@chromium.org

[piman, 2016-05-23 23:20:14]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2000923002/#ps40001
(title: "review comments, build fixes")

[piman, 2016-05-23 23:20:19]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-05-23 23:21:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2000923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2000923002/40001

[commit-bot: I haz the power, 2016-05-23 23:36:42]

Description was changed from

==========
Only allow TexStorage2DEXT if we expose the extension

If the underlying driver doesn't support the necessary extensions,
TexStorageImpl crashes.
Also, make sure we enable the extension on es3 command buffers (and thus,
possibly disable BGRA if it is not compatible).

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Only allow TexStorage2DEXT if we expose the extension

If the underlying driver doesn't support the necessary extensions,
TexStorageImpl crashes.
Also, make sure we enable the extension on es3 command buffers (and thus,
possibly disable BGRA if it is not compatible).

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-05-23 23:36:43]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-23 23:38:59]

Description was changed from

==========
Only allow TexStorage2DEXT if we expose the extension

If the underlying driver doesn't support the necessary extensions,
TexStorageImpl crashes.
Also, make sure we enable the extension on es3 command buffers (and thus,
possibly disable BGRA if it is not compatible).

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Only allow TexStorage2DEXT if we expose the extension

If the underlying driver doesn't support the necessary extensions,
TexStorageImpl crashes.
Also, make sure we enable the extension on es3 command buffers (and thus,
possibly disable BGRA if it is not compatible).

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a756b558c63783ad5d94f805720a772df7357c7d
Cr-Commit-Position: refs/heads/master@{#395466}
==========

[commit-bot: I haz the power, 2016-05-23 23:39:00]

Patchset 2 (id:??) landed as
https://crrev.com/a756b558c63783ad5d94f805720a772df7357c7d
Cr-Commit-Position: refs/heads/master@{#395466}