Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2454323004: Make layout test harness extensible with custom layout tests directory (Closed)
Patch Set: Undo non test harness changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
index d5b3abb6932e045775b750acd73dfd0dc5e9d052..433a21f773a918136489f4cf8e59dc53ade0ddcc 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -957,6 +957,9 @@ class Port(object):
return self._webkit_finder.path_to_script(script_name)
def layout_tests_dir(self):
+ custom_layout_tests_dir = self.get_option('layout_tests_directory')
+ if custom_layout_tests_dir:
+ return custom_layout_tests_dir
return self._webkit_finder.layout_tests_dir()
def perf_tests_dir(self):
@@ -1096,6 +1099,9 @@ class Port(object):
def inspector_debug_directory(self):
return self.path_from_webkit_base('Source', 'devtools', 'front_end')
+ def apache_config_directory(self):
+ return self.path_from_webkit_base('Tools', 'Scripts', 'apache_config')
+
def default_results_directory(self):
"""Absolute path to the default place to store the test results."""
return self._build_path('layout-test-results')
@@ -1517,7 +1523,7 @@ class Port(object):
return config_file_from_env
config_file_name = self._apache_config_file_name_for_platform()
- return self._filesystem.join(self.layout_tests_dir(), 'http', 'conf', config_file_name)
+ return self._filesystem.join(self.apache_config_directory(), config_file_name)
#
# PROTECTED ROUTINES

Powered by Google App Engine
This is Rietveld 408576698