Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2454323004: Make layout test harness extensible with custom layout tests directory (Closed)
Patch Set: Undo non test harness changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 939 matching lines...) Expand 10 before | Expand all | Expand 10 after
950 def path_from_webkit_base(self, *comps): 950 def path_from_webkit_base(self, *comps):
951 return self._webkit_finder.path_from_webkit_base(*comps) 951 return self._webkit_finder.path_from_webkit_base(*comps)
952 952
953 def path_from_chromium_base(self, *comps): 953 def path_from_chromium_base(self, *comps):
954 return self._webkit_finder.path_from_chromium_base(*comps) 954 return self._webkit_finder.path_from_chromium_base(*comps)
955 955
956 def path_to_script(self, script_name): 956 def path_to_script(self, script_name):
957 return self._webkit_finder.path_to_script(script_name) 957 return self._webkit_finder.path_to_script(script_name)
958 958
959 def layout_tests_dir(self): 959 def layout_tests_dir(self):
960 custom_layout_tests_dir = self.get_option('layout_tests_directory')
961 if custom_layout_tests_dir:
962 return custom_layout_tests_dir
960 return self._webkit_finder.layout_tests_dir() 963 return self._webkit_finder.layout_tests_dir()
961 964
962 def perf_tests_dir(self): 965 def perf_tests_dir(self):
963 return self._webkit_finder.perf_tests_dir() 966 return self._webkit_finder.perf_tests_dir()
964 967
965 def skipped_layout_tests(self, test_list): 968 def skipped_layout_tests(self, test_list):
966 """Returns tests skipped outside of the TestExpectations files.""" 969 """Returns tests skipped outside of the TestExpectations files."""
967 return set(self._skipped_tests_for_unsupported_features(test_list)) 970 return set(self._skipped_tests_for_unsupported_features(test_list))
968 971
969 def skips_test(self, test, generic_expectations, full_expectations): 972 def skips_test(self, test, generic_expectations, full_expectations):
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
1089 1092
1090 def perf_results_directory(self): 1093 def perf_results_directory(self):
1091 return self._build_path() 1094 return self._build_path()
1092 1095
1093 def inspector_build_directory(self): 1096 def inspector_build_directory(self):
1094 return self._build_path('resources', 'inspector') 1097 return self._build_path('resources', 'inspector')
1095 1098
1096 def inspector_debug_directory(self): 1099 def inspector_debug_directory(self):
1097 return self.path_from_webkit_base('Source', 'devtools', 'front_end') 1100 return self.path_from_webkit_base('Source', 'devtools', 'front_end')
1098 1101
1102 def apache_config_directory(self):
1103 return self.path_from_webkit_base('Tools', 'Scripts', 'apache_config')
1104
1099 def default_results_directory(self): 1105 def default_results_directory(self):
1100 """Absolute path to the default place to store the test results.""" 1106 """Absolute path to the default place to store the test results."""
1101 return self._build_path('layout-test-results') 1107 return self._build_path('layout-test-results')
1102 1108
1103 def setup_test_run(self): 1109 def setup_test_run(self):
1104 """Perform port-specific work at the beginning of a test run.""" 1110 """Perform port-specific work at the beginning of a test run."""
1105 # Delete the disk cache if any to ensure a clean test run. 1111 # Delete the disk cache if any to ensure a clean test run.
1106 dump_render_tree_binary_path = self._path_to_driver() 1112 dump_render_tree_binary_path = self._path_to_driver()
1107 cachedir = self._filesystem.dirname(dump_render_tree_binary_path) 1113 cachedir = self._filesystem.dirname(dump_render_tree_binary_path)
1108 cachedir = self._filesystem.join(cachedir, "cache") 1114 cachedir = self._filesystem.join(cachedir, "cache")
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
1510 1516
1511 This is needed only by ports that use the apache_http_server module. 1517 This is needed only by ports that use the apache_http_server module.
1512 """ 1518 """
1513 config_file_from_env = self.host.environ.get('WEBKIT_HTTP_SERVER_CONF_PA TH') 1519 config_file_from_env = self.host.environ.get('WEBKIT_HTTP_SERVER_CONF_PA TH')
1514 if config_file_from_env: 1520 if config_file_from_env:
1515 if not self._filesystem.exists(config_file_from_env): 1521 if not self._filesystem.exists(config_file_from_env):
1516 raise IOError('%s was not found on the system' % config_file_fro m_env) 1522 raise IOError('%s was not found on the system' % config_file_fro m_env)
1517 return config_file_from_env 1523 return config_file_from_env
1518 1524
1519 config_file_name = self._apache_config_file_name_for_platform() 1525 config_file_name = self._apache_config_file_name_for_platform()
1520 return self._filesystem.join(self.layout_tests_dir(), 'http', 'conf', co nfig_file_name) 1526 return self._filesystem.join(self.apache_config_directory(), config_file _name)
1521 1527
1522 # 1528 #
1523 # PROTECTED ROUTINES 1529 # PROTECTED ROUTINES
1524 # 1530 #
1525 # The routines below should only be called by routines in this class 1531 # The routines below should only be called by routines in this class
1526 # or any of its subclasses. 1532 # or any of its subclasses.
1527 # 1533 #
1528 1534
1529 def _apache_version(self): 1535 def _apache_version(self):
1530 config = self._executive.run_command([self.path_to_apache(), '-v']) 1536 config = self._executive.run_command([self.path_to_apache(), '-v'])
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
1831 1837
1832 def __init__(self, base, args, reference_args=None): 1838 def __init__(self, base, args, reference_args=None):
1833 self.name = base 1839 self.name = base
1834 self.base = base 1840 self.base = base
1835 self.args = args 1841 self.args = args
1836 self.reference_args = args if reference_args is None else reference_args 1842 self.reference_args = args if reference_args is None else reference_args
1837 self.tests = set() 1843 self.tests = set()
1838 1844
1839 def __repr__(self): 1845 def __repr__(self):
1840 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args) 1846 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698