Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/resources/md_history/history_item.js

Issue 2454303002: [MD History] Add full time hover text to dates in history items. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_history/history_item.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/history_item.js
diff --git a/chrome/browser/resources/md_history/history_item.js b/chrome/browser/resources/md_history/history_item.js
index e064ec6710efbb08bdb2ce0cd7a0d3f1e39c6ef5..abd3d1b22c61cf5d371b6c7f78ce7e262a61d0b9 100644
--- a/chrome/browser/resources/md_history/history_item.js
+++ b/chrome/browser/resources/md_history/history_item.js
@@ -300,6 +300,15 @@ cr.define('md_history', function() {
return this.item.dateRelativeDay;
return HistoryItem.searchResultsTitle(numberOfItems, search);
},
+
+ /**
+ * @param {HistoryItem} item
+ * @return {string} The full time string for this item.
+ * @private
+ */
+ getTimeTitle_: function(item) {
+ return new Date(item.time).toString();
Dan Beam 2016/10/28 03:41:40 nit: can we lazily generate this? does doing this
calamity 2016/10/28 06:01:58 Good catch. Across 60 items, this saves ~5ms. *shr
+ },
});
/**
« no previous file with comments | « chrome/browser/resources/md_history/history_item.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698