Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2454173002: Correcting issues noted in a11y review for Desktop FRE. (Closed)

Created:
4 years, 1 month ago by tmartino
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correcting issues noted in a11y review for Desktop FRE. BUG=657174, 659759 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/49d714d3f447e3f54372a6a735d18694846a503a Cr-Commit-Position: refs/heads/master@{#428250}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressing dbeam comments #

Total comments: 3

Patch Set 3 : More dbeam feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/resources/welcome/welcome.css View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/welcome/welcome.html View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/welcome/welcome.js View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
tmartino
4 years, 1 month ago (2016-10-27 19:00:45 UTC) #3
Dan Beam
https://codereview.chromium.org/2454173002/diff/1/chrome/browser/resources/welcome/welcome.css File chrome/browser/resources/welcome/welcome.css (right): https://codereview.chromium.org/2454173002/diff/1/chrome/browser/resources/welcome/welcome.css#newcode123 chrome/browser/resources/welcome/welcome.css:123: font-weight: 500; you probably don't need the document.fonts.load() line ...
4 years, 1 month ago (2016-10-27 19:16:07 UTC) #4
tmartino
On 2016/10/27 at 19:16:07, dbeam wrote: > https://codereview.chromium.org/2454173002/diff/1/chrome/browser/resources/welcome/welcome.css > File chrome/browser/resources/welcome/welcome.css (right): > > https://codereview.chromium.org/2454173002/diff/1/chrome/browser/resources/welcome/welcome.css#newcode123 ...
4 years, 1 month ago (2016-10-27 19:40:37 UTC) #5
Dan Beam
https://codereview.chromium.org/2454173002/diff/20001/chrome/browser/resources/welcome/welcome.css File chrome/browser/resources/welcome/welcome.css (right): https://codereview.chromium.org/2454173002/diff/20001/chrome/browser/resources/welcome/welcome.css#newcode138 chrome/browser/resources/welcome/welcome.css:138: background: -webkit-image-set(url(chrome://welcome/logo.png) 1x, nit: background-image https://codereview.chromium.org/2454173002/diff/20001/chrome/browser/resources/welcome/welcome.css#newcode140 chrome/browser/resources/welcome/welcome.css:140: background-position: center; ...
4 years, 1 month ago (2016-10-27 21:20:25 UTC) #6
tmartino
On 2016/10/27 at 21:20:25, dbeam wrote: > https://codereview.chromium.org/2454173002/diff/20001/chrome/browser/resources/welcome/welcome.css > File chrome/browser/resources/welcome/welcome.css (right): > > https://codereview.chromium.org/2454173002/diff/20001/chrome/browser/resources/welcome/welcome.css#newcode138 ...
4 years, 1 month ago (2016-10-27 23:14:11 UTC) #7
Dan Beam
lgtm
4 years, 1 month ago (2016-10-27 23:25:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454173002/40001
4 years, 1 month ago (2016-10-28 00:01:06 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-28 02:20:34 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 02:24:30 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/49d714d3f447e3f54372a6a735d18694846a503a
Cr-Commit-Position: refs/heads/master@{#428250}

Powered by Google App Engine
This is Rietveld 408576698