chrome/browser/resources/welcome/welcome.html - Issue 2454173002: Correcting issues noted in a11y review for Desktop FRE.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/welcome/welcome.html

Issue 2454173002: Correcting issues noted in a11y review for Desktop FRE. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>$i18n{headerText}</title>	4 <title>$i18n{headerText}</title>

5	5

6 <link rel="import" href="chrome://resources/html/cr.html">	6 <link rel="import" href="chrome://resources/html/cr.html">

7 <link rel="import" href="chrome://resources/html/polymer.html">	7 <link rel="import" href="chrome://resources/html/polymer.html">

8 <link rel="import" href="chrome://resources/html/util.html">	8 <link rel="import" href="chrome://resources/html/util.html">

9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-bu tton.html">	9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-bu tton.html">

10 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.ht ml">	10 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.ht ml">

11	11

12 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">	12 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

13 <link rel="stylesheet" href="chrome://welcome/welcome.css">	13 <link rel="stylesheet" href="chrome://welcome/welcome.css">

14 </head>	14 </head>

15 <body>	15 <body>

16 <div class="content">	16 <div class="content">

17 <div class="logo">	17 <div class="logo">

18 <div class="logo-icon"></div>	18 <img class="logo-icon" alt="chrome logo" src="chrome://welcome/logo.png"
Dan Beam 2016/10/27 19:16:07 i think it's more useful to hide this from screenr i think it's more useful to hide this from screenreaders than try to describe it. can we just use role="presentation" (maybe?) or aria-hidden="true" in the original markup?
	19 srcset="chrome://welcome/logo.png 1x, chrome://welcome/logo2x.png 2x" >
	Dan Beam 2016/10/27 19:16:07 80 col wrap 80 col wrap
19 <div class="logo-shadow"></div>	20 <div class="logo-shadow"></div>

20 </div>	21 </div>

21 <div class="heading">$i18n{headerText}</div>	22 <div class="heading">$i18n{headerText}</div>

22 <if expr="_google_chrome">	23 <if expr="_google_chrome">

23 <div class="subheading">$i18n{subheaderText}</div>	24 <div class="subheading">$i18n{subheaderText}</div>

24 </if>	25 </if>

25 <div class="signin">	26 <div class="signin">

26 <div class="signin-description">$i18n{descriptionText}</div>	27 <div class="signin-description">$i18n{descriptionText}</div>

27 <div class="signin-buttons">	28 <div class="signin-buttons">

28 <paper-button class="action" id="accept-button">$i18n{acceptText}</paper -button>	29 <paper-button class="action" id="accept-button">$i18n{acceptText}</paper -button>

29 <a href="#" class="link" id="decline-button">$i18n{declineText}</a>	30 <a href="#" class="link" id="decline-button">$i18n{declineText}</a>

30 </div>	31 </div>

31 </div>	32 </div>

32 </div>	33 </div>

33 <div class="watermark"></div>	34 <div class="watermark"></div>

34 <script src="chrome://welcome/welcome.js"></script>	35 <script src="chrome://welcome/welcome.js"></script>

35 </body>	36 </body>

36 </html>	37 </html>

OLD	NEW

« chrome/browser/resources/welcome/welcome.css ('K') | « chrome/browser/resources/welcome/welcome.css ('k') | no next file » | no next file with comments »