Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2454073005: Add isComposing support for KeyboardEvents (Closed)

Created:
4 years, 1 month ago by dtapuska
Modified:
4 years, 1 month ago
Reviewers:
bokan, Rick Byers
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add isComposing support for KeyboardEvents Initialize isComposing based on the value that the InputMethodController has when we are constructing natively backed events. Approved Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/6o1W8mVUDsA/JOKZ-aRfBwAJ BUG=625686 Committed: https://crrev.com/3c3223b3a1e3c570aab417f3c89eb0410341c5b8 Cr-Commit-Position: refs/heads/master@{#429133}

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Rebase #

Patch Set 4 : Fix windows and linux #

Messages

Total messages: 26 (19 generated)
dtapuska
4 years, 1 month ago (2016-10-31 22:47:57 UTC) #8
bokan
lgtm. Ship it!
4 years, 1 month ago (2016-11-01 17:31:16 UTC) #13
dtapuska
On 2016/11/01 17:31:16, bokan wrote: > lgtm. Ship it! rbyers@ please stamp!
4 years, 1 month ago (2016-11-01 19:52:48 UTC) #18
Rick Byers
On 2016/11/01 19:52:48, dtapuska wrote: > On 2016/11/01 17:31:16, bokan wrote: > > lgtm. Ship ...
4 years, 1 month ago (2016-11-01 20:24:54 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454073005/60001
4 years, 1 month ago (2016-11-01 20:25:42 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-01 22:12:54 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 22:16:15 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3c3223b3a1e3c570aab417f3c89eb0410341c5b8
Cr-Commit-Position: refs/heads/master@{#429133}

Powered by Google App Engine
This is Rietveld 408576698