Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

Issue 2454073005: Add isComposing support for KeyboardEvents (Closed)
Patch Set: Fix windows and linux Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/events/KeyboardEventInit.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
index cb5dea221c5c17592e5e3fb7aa0f16aeda2147f3..85a2341336f5644cfc8e5999c6244106d20a5cf7 100644
--- a/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
@@ -56,8 +56,11 @@ namespace blink {
KeyboardEvent* createKeyboardEventWithLocation(
KeyboardEvent::KeyLocationCode location) {
- return KeyboardEvent::create("keydown", true, true, 0, "", "", location,
- PlatformEvent::NoModifiers, 0);
+ KeyboardEventInit keyEventInit;
+ keyEventInit.setBubbles(true);
+ keyEventInit.setCancelable(true);
+ keyEventInit.setLocation(location);
+ return new KeyboardEvent("keydown", keyEventInit);
}
int getModifiersForKeyLocationCode(KeyboardEvent::KeyLocationCode location) {
« no previous file with comments | « third_party/WebKit/Source/core/events/KeyboardEventInit.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698