Issue 24538002: add isolate parameter to ThrowException

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24538002: add isolate parameter to ThrowException (Closed)

Created:
7 years, 2 months ago by dcarney

Modified:
7 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

add isolate parameter to ThrowException R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16955

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -70 lines)			Patch
M	include/v8.h	View	1	2 chunks	+9 lines, -6 lines	0 comments	Download
M	samples/lineprocessor.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/shell.cc	View	1	3 chunks	+12 lines, -6 lines	0 comments	Download
M	src/api.cc	View	1	3 chunks	+16 lines, -11 lines	0 comments	Download
M	src/d8-posix.cc	View	1	13 chunks	+29 lines, -22 lines	0 comments	Download
M	src/extensions/externalize-string-extension.cc	View	1	5 chunks	+6 lines, -5 lines	0 comments	Download
M	test/cctest/test-accessors.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	15 chunks	+18 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a suggestion. Feel free to ignore if you don't think moving it into ...

7 years, 2 months ago (2013-09-25 09:18:08 UTC) #2

dcarney

https://codereview.chromium.org/24538002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/24538002/diff/1/include/v8.h#newcode3800 include/v8.h:3800: Local<Value> V8_EXPORT ThrowException(Isolate* isolate, On 2013/09/25 09:18:08, Michael Starzinger ...

7 years, 2 months ago (2013-09-25 09:29:36 UTC) #3

dcarney

7 years, 2 months ago (2013-09-26 07:38:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r16955 (presubmit successful).

Expand Messages | Collapse Messages

Issue 24538002: add isolate parameter to ThrowException (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages