 Chromium Code Reviews
 Chromium Code Reviews Issue 24538002:
  add isolate parameter to ThrowException  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
    
  
    Issue 24538002:
  add isolate parameter to ThrowException  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge| OLD | NEW | 
|---|---|
| 1 // Copyright 2012 the V8 project authors. All rights reserved. | 1 // Copyright 2012 the V8 project authors. All rights reserved. | 
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without | 
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are | 
| 4 // met: | 4 // met: | 
| 5 // | 5 // | 
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright | 
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. | 
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above | 
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following | 
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided | 
| (...skipping 3779 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3790 | 3790 | 
| 3791 typedef void (*MessageCallback)(Handle<Message> message, Handle<Value> error); | 3791 typedef void (*MessageCallback)(Handle<Message> message, Handle<Value> error); | 
| 3792 | 3792 | 
| 3793 | 3793 | 
| 3794 /** | 3794 /** | 
| 3795 * Schedules an exception to be thrown when returning to JavaScript. When an | 3795 * Schedules an exception to be thrown when returning to JavaScript. When an | 
| 3796 * exception has been scheduled it is illegal to invoke any JavaScript | 3796 * exception has been scheduled it is illegal to invoke any JavaScript | 
| 3797 * operation; the caller must return immediately and only after the exception | 3797 * operation; the caller must return immediately and only after the exception | 
| 3798 * has been handled does it become legal to invoke JavaScript operations. | 3798 * has been handled does it become legal to invoke JavaScript operations. | 
| 3799 */ | 3799 */ | 
| 3800 Local<Value> V8_EXPORT ThrowException(Isolate* isolate, | |
| 
Michael Starzinger
2013/09/25 09:18:08
Does it make sense to even move this into the Isol
 
dcarney
2013/09/25 09:29:36
sounds superior
 | |
| 3801 Local<Value> exception); | |
| 3802 | |
| 3803 // TODO(dcarney): remove | |
| 3800 Handle<Value> V8_EXPORT ThrowException(Handle<Value> exception); | 3804 Handle<Value> V8_EXPORT ThrowException(Handle<Value> exception); | 
| 3801 | 3805 | 
| 3802 /** | 3806 /** | 
| 3803 * Create new error objects by calling the corresponding error object | 3807 * Create new error objects by calling the corresponding error object | 
| 3804 * constructor with the message. | 3808 * constructor with the message. | 
| 3805 */ | 3809 */ | 
| 3806 class V8_EXPORT Exception { | 3810 class V8_EXPORT Exception { | 
| 3807 public: | 3811 public: | 
| 3808 static Local<Value> RangeError(Handle<String> message); | 3812 static Local<Value> RangeError(Handle<String> message); | 
| 3809 static Local<Value> ReferenceError(Handle<String> message); | 3813 static Local<Value> ReferenceError(Handle<String> message); | 
| (...skipping 2668 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 6478 */ | 6482 */ | 
| 6479 | 6483 | 
| 6480 | 6484 | 
| 6481 } // namespace v8 | 6485 } // namespace v8 | 
| 6482 | 6486 | 
| 6483 | 6487 | 
| 6484 #undef TYPE_CHECK | 6488 #undef TYPE_CHECK | 
| 6485 | 6489 | 
| 6486 | 6490 | 
| 6487 #endif // V8_H_ | 6491 #endif // V8_H_ | 
| OLD | NEW |